Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(fuselage): Add loading Skeleton to CodeSnippet #632

Merged
merged 2 commits into from
Feb 1, 2022
Merged

feat(fuselage): Add loading Skeleton to CodeSnippet #632

merged 2 commits into from
Feb 1, 2022

Conversation

PedroRorato
Copy link
Contributor

Proposed changes (including videos or screenshots)

  • Added a loading Skeleton to CodeSnippet component.
  • Added an example to Storybook.
    Screen Shot 2022-02-01 at 09 44 57

Further comments

  • Sometimes the code inside CodeSnippet needs to get a token from API, so this is a similar solution to the one used in InputBox

@PedroRorato PedroRorato requested a review from a team February 1, 2022 12:57
@tassoevan tassoevan merged commit 46fe245 into develop Feb 1, 2022
@tassoevan tassoevan deleted the feat-code-snippet-skeleton branch February 1, 2022 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tassoevan tassoevan tassoevan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PedroRorato @tassoevan