-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fuselage): MessageEmoji and ThreadMessageEmoji components #709
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| import type { ReactNode } from 'react'; | ||
| import React from 'react'; | ||
|
|
||
| import { MessageEmojiBase } from './MessageEmojiBase'; | ||
|
|
||
| type MessageEmojiProps = { | ||
| name: string; | ||
| className?: string; | ||
| image?: string; | ||
| big?: boolean; | ||
| children?: ReactNode; | ||
| }; | ||
|
|
||
| export const MessageEmoji = ({ | ||
| name, | ||
| className, | ||
| image, | ||
| big, | ||
| children, | ||
| }: MessageEmojiProps) => ( | ||
| <MessageEmojiBase | ||
| className={[ | ||
| 'rcx-message__emoji', | ||
| className, | ||
| big && 'rcx-message__emoji--big', | ||
| ] | ||
| .filter(Boolean) | ||
| .join(' ')} | ||
| name={name} | ||
| image={image} | ||
| children={children} | ||
| /> | ||
| ); | ||
22 changes: 22 additions & 0 deletions
22
packages/fuselage/src/components/Message/MessageEmojiBase.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| import type { ReactNode } from 'react'; | ||
| import React from 'react'; | ||
|
|
||
| type MessageEmojiBaseProps = { | ||
| name: string; | ||
| className?: string; | ||
| children?: ReactNode; | ||
| image?: string; | ||
| }; | ||
|
|
||
| export const MessageEmojiBase = ({ | ||
| name, | ||
| className, | ||
| image, | ||
| children, | ||
| }: MessageEmojiBaseProps) => ( | ||
| <span | ||
| className={`${className || ''} ${name}`} | ||
| style={image && image.length ? { backgroundImage: image } : undefined} | ||
| children={children} | ||
| /> | ||
| ); |
13 changes: 10 additions & 3 deletions
13
packages/fuselage/src/components/Message/MessageReactions/MessageReactionEmoji.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,25 @@ | ||
| import type { ReactNode } from 'react'; | ||
| import React from 'react'; | ||
|
|
||
| import { MessageEmojiBase } from '../MessageEmojiBase'; | ||
|
|
||
| type MessageReactionEmojiProps = { | ||
| name: string; | ||
| className?: string; | ||
| children?: ReactNode; | ||
| image?: string; | ||
| }; | ||
|
|
||
| export const MessageReactionEmoji = ({ | ||
| name, | ||
| className, | ||
| image, | ||
| children, | ||
| }: MessageReactionEmojiProps) => ( | ||
| <div | ||
| className={`rcx-message-reactions__emoji ${name} ${className}`} | ||
| style={image && image.length ? { backgroundImage: image } : undefined} | ||
| <MessageEmojiBase | ||
| className={`rcx-message-reactions__emoji ${className || ''}`} | ||
| name={name} | ||
| image={image} | ||
| children={children} | ||
| /> | ||
| ); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a conditional here? cause when the className is undefined we will render the emoji text like
:random-text:so we don't need the emoji style in this scenario.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also we need the
namein the class name to render the correct style ofemojiThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kind of agree with the first comment. I know we need for this to be "sizeless" whenever the emoji doesn't exist, but not sure if we should depend on the className. For ex: if for some reason we decide to pass another className, this implementation falls apart. Maybe we need an aditional prop?
On the second one, I don't se a reason to add the name in the className, because that is Application specific. If the application needs to send the name as a className, it can do so by including it in the className prop.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realized that for the first comment, we can just not use this component :p. I'll leave it like it is...