Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove italic style from system messages #830

Merged
merged 2 commits into from
Aug 24, 2022
Merged

Conversation

hugocostadev
Copy link
Contributor

@hugocostadev hugocostadev commented Aug 19, 2022

Proposed changes (including videos or screenshots)

The design team raised an issue to remove the italic style from the system message component.
It was removed from the <MessageSystem> component but there are several messages with other font styles (italic and bold) at Rocket.Chat messages that are being checked with the Design team if they should be removed, but it is not a blocker.

RocketChat/Rocket.Chat#26655

Issue(s)

Further comments

TO DO:

  • If the other font-styles should be removed from Rocket.Chat the PR will be included at main repository

Copy link
Member

@ggazzo ggazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you provide me more info about this decision?

@hugocostadev
Copy link
Contributor Author

could you provide me more info about this decision?

Already aligned in private

@gabriellsh gabriellsh requested a review from ggazzo August 23, 2022 18:29
@kodiakhq kodiakhq bot merged commit 96df38b into develop Aug 24, 2022
@kodiakhq kodiakhq bot deleted the fix/system-messages branch August 24, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants