Hubot script to accept the room name #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Linked to RocketChat/Rocket.Chat#7102 |
geekgonecrazy
requested changes
Jun 8, 2017
src/rocketchat.coffee
Outdated
| if newmsg.t is 'uj' | ||
| @robot.receive new EnterMessage user, null, newmsg._id | ||
| else | ||
| @chatdriver.getRommName(newmsg.rid).then((roomName)=> |
There was a problem hiding this comment.
Can we fix the spelling on this to getRoomName ?
Thanks!
src/rocketchat_driver.coffee
Outdated
| @@ -39,6 +40,9 @@ class RocketChatDriver | |||
| getRoomId: (room) => | |||
| @tryCache _roomIdCache, 'getRoomIdByNameOrId', room, 'Room ID' | |||
|
|
|||
| getRommName: (room) => | |||
There was a problem hiding this comment.
Same fix here of course :)
src/rocketchat_driver.coffee
Outdated
| changedMsgQuery = @messages.reactiveQuery {"_id": id} | ||
| if changedMsgQuery.result && changedMsgQuery.result.length > 0 | ||
| # console.log('result:', JSON.stringify(changedMsgQuery.result, null, 2)) | ||
| # console.log('result:', JSON.stringify(changedMsgQuery.result, null, 2)) |
There was a problem hiding this comment.
Can we also get these comments moved back in line like they were?
There was a problem hiding this comment.
I'm sorry I use the ide automatically formatted
geekgonecrazy
approved these changes
Jun 13, 2017
|
Can this be merged? I think v57 of Rocket.chat has the necessary API (https://github.com/RocketChat/Rocket.Chat/releases/tag/0.57.0), doesn't it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We expect in messages received or room name, rather than the room id, because the room id cannot access to the page and not easy to understand #213