Updated base builders to be less strict with properties +semver:minor

RocketSurgeonsGuild · Jun 30, 2019 · e521e17 · e521e17
1 parent 09e5cf7
commit e521e17
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 12 deletions.
diff --git a/src/Conventions/ConventionBuilder.cs b/src/Conventions/ConventionBuilder.cs
@@ -25,8 +25,8 @@ protected ConventionBuilder(
             IConventionScanner scanner,
             IAssemblyProvider assemblyProvider,
             IAssemblyCandidateFinder assemblyCandidateFinder,
-            IServiceProviderDictionary serviceProperties
-        ) : base(scanner, serviceProperties)
+            IDictionary<object, object> properties
+        ) : base(scanner, properties)
         {
             AssemblyProvider = assemblyProvider ?? throw new ArgumentNullException(nameof(assemblyProvider));
             AssemblyCandidateFinder = assemblyCandidateFinder ?? throw new ArgumentNullException(nameof(assemblyCandidateFinder));

diff --git a/src/Conventions/ConventionContainerBuilder.cs b/src/Conventions/ConventionContainerBuilder.cs
@@ -20,12 +20,12 @@ public abstract class ConventionContainerBuilder<TBuilder, TConvention, TDelegat
     {
         protected ConventionContainerBuilder(
             IConventionScanner scanner,
-            IServiceProviderDictionary serviceProperties)
+            IDictionary<object, object> properties)
         {
             Scanner = scanner ?? throw new ArgumentNullException(nameof(scanner));
-            ServiceProperties = serviceProperties ?? new ServiceProviderDictionary();
+            Properties = properties ?? throw new ArgumentNullException(nameof(properties));
 
-            if (!Properties.TryGetValue(typeof(IConventionScanner), out var _))
+            if (!Properties.TryGetValue(typeof(IConventionScanner), out _))
                 Properties[typeof(IConventionScanner)] = Scanner;
         }
 
@@ -44,13 +44,7 @@ public virtual object this[object item]
         /// A central location for sharing state between components during the convention building process.
         /// </summary>
         /// <value>The properties.</value>
-        public IServiceProviderDictionary ServiceProperties { get; }
-
-        /// <summary>
-        /// A central location for sharing state between components during the convention building process.
-        /// </summary>
-        /// <value>The properties.</value>
-        public IDictionary<object, object> Properties => ServiceProperties;
+        public IDictionary<object, object> Properties { get; }
 
         /// <summary>
         /// Gets the scanner.