Fixed static generic type scanning #1518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-driscoll
force-pushed
the
fix/generic-type-scanning
branch
from
1cfae31 to
abefe48
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #1518 +/- ##
==========================================
+ Coverage 71.16% 71.54% +0.37%
==========================================
Files 105 105
Lines 4880 4903 +23
Branches 430 432 +2
==========================================
+ Hits 3473 3508 +35
+ Misses 1407 1395 -12 ☔ View full report in Codecov by Sentry. |
david-driscoll
added a commit
that referenced
this pull request
Apr 25, 2024
* wip on adding async for all the new host builder style interfaces (#1495) * wip on adding async for all the new host builder style interfaces * Continued work on async changes for the new hosting patterns * Automatically linting code * working on selecting the version of .net to run * next up dealing with dependency injection * it compiles, async all the things, remove a lot of legacy * Unit tests now pass, changed around the base interface from IServiceProvider to IServiceProviderDictionary * Fixed the build failures with samples * Automatically linting code * fixed warnings * Removing a few projects that are not needed. * minor package reference change * Automatically linting code * Added types provider to assembly provider * Added initial support for generated AssemblyProvider * refined things so we have proper yield returns now! * added tests for self assembly, duplicating lines, as well as dependent assemblies * Started work on generated assembly provider, added runtime and compile time tests. Working through compile time behaviors now. * all tests now pass... onto serialization! * time to serialize * configured in place most of the json * more adjustments to assemblies provider compilation * Updated snapshots, most tests now pass! * All tests pass... * all tests pass...maybe it works... * Automatically linting code * Updated project * Updates to analyzers, now output the new format for imports and assembly providers * stuff and things * All the pass... * Updated verified files * Updated verified files * attempt to fix tests * Fixed last tests... * couple minor docs changes * warnings pass * format pass * Automatically linting code * bump in the night * Automatically linting code --------- Co-authored-by: Rocket Understudy <33589210+rsg-bot@users.noreply.github.com> * Updated gitversion config * Rebase/with master (#1510) * Update dependency Verify.Xunit to v23.7.2 * Update dependency jetbrains.resharper.globaltools to v2024 * Update codecov/codecov-action action to v4.3.0 * Update dependency Polyfill to v4.5.0 * Update dependency FakeItEasy to v8.2.0 * Update xunit * Update dependency Verify.Xunit to v24 * Update dependency dotnet-outdated-tool to v4.6.1 * Update dependency Verify.Xunit to v24.1.0 * Update dependency Microsoft.Playwright to v1.43.0 (#1501) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Revert "Rebase/with master (#1508)" (#1509) This reverts commit 456f450. * wip on adding async for all the new host builder style interfaces (#1495) * wip on adding async for all the new host builder style interfaces * Continued work on async changes for the new hosting patterns * Automatically linting code * working on selecting the version of .net to run * next up dealing with dependency injection * it compiles, async all the things, remove a lot of legacy * Unit tests now pass, changed around the base interface from IServiceProvider to IServiceProviderDictionary * Fixed the build failures with samples * Automatically linting code * fixed warnings * Removing a few projects that are not needed. * minor package reference change * Automatically linting code * Added types provider to assembly provider * Added initial support for generated AssemblyProvider * refined things so we have proper yield returns now! * added tests for self assembly, duplicating lines, as well as dependent assemblies * Started work on generated assembly provider, added runtime and compile time tests. Working through compile time behaviors now. * all tests now pass... onto serialization! * time to serialize * configured in place most of the json * more adjustments to assemblies provider compilation * Updated snapshots, most tests now pass! * All tests pass... * all tests pass...maybe it works... * Automatically linting code * Updated project * Updates to analyzers, now output the new format for imports and assembly providers * stuff and things * All the pass... * Updated verified files * Updated verified files * attempt to fix tests * Fixed last tests... * couple minor docs changes * warnings pass * format pass * Automatically linting code * bump in the night * Automatically linting code --------- Co-authored-by: Rocket Understudy <33589210+rsg-bot@users.noreply.github.com> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Rocket Understudy <33589210+rsg-bot@users.noreply.github.com> * Feature/work with nested typeof (#1512) * Update dependency Verify.Xunit to v23.7.2 * Update dependency jetbrains.resharper.globaltools to v2024 * Update codecov/codecov-action action to v4.3.0 * Update dependency Polyfill to v4.5.0 * Update dependency FakeItEasy to v8.2.0 * Update xunit * Update dependency Verify.Xunit to v24 * Update dependency dotnet-outdated-tool to v4.6.1 * Update dependency Verify.Xunit to v24.1.0 * Update dependency Microsoft.Playwright to v1.43.0 (#1501) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Revert "Rebase/with master (#1508)" (#1509) This reverts commit 456f450. * wip on adding async for all the new host builder style interfaces (#1495) * wip on adding async for all the new host builder style interfaces * Continued work on async changes for the new hosting patterns * Automatically linting code * working on selecting the version of .net to run * next up dealing with dependency injection * it compiles, async all the things, remove a lot of legacy * Unit tests now pass, changed around the base interface from IServiceProvider to IServiceProviderDictionary * Fixed the build failures with samples * Automatically linting code * fixed warnings * Removing a few projects that are not needed. * minor package reference change * Automatically linting code * Added types provider to assembly provider * Added initial support for generated AssemblyProvider * refined things so we have proper yield returns now! * added tests for self assembly, duplicating lines, as well as dependent assemblies * Started work on generated assembly provider, added runtime and compile time tests. Working through compile time behaviors now. * all tests now pass... onto serialization! * time to serialize * configured in place most of the json * more adjustments to assemblies provider compilation * Updated snapshots, most tests now pass! * All tests pass... * all tests pass...maybe it works... * Automatically linting code * Updated project * Updates to analyzers, now output the new format for imports and assembly providers * stuff and things * All the pass... * Updated verified files * Updated verified files * attempt to fix tests * Fixed last tests... * couple minor docs changes * warnings pass * format pass * Automatically linting code * bump in the night * Automatically linting code --------- Co-authored-by: Rocket Understudy <33589210+rsg-bot@users.noreply.github.com> * Fixed typeof values using the metadata name * fixed compiler errors * pushed changes * Automatically linting code * Updated tests view * Automatically linting code * Updated tests view --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Rocket Understudy <33589210+rsg-bot@users.noreply.github.com> * Update/next (#1514) * Update dependency Verify.Xunit to v23.7.2 * Update dependency jetbrains.resharper.globaltools to v2024 * Update codecov/codecov-action action to v4.3.0 * Update dependency Polyfill to v4.5.0 * Update dependency FakeItEasy to v8.2.0 * Update xunit * Update dependency Verify.Xunit to v24 * Update dependency dotnet-outdated-tool to v4.6.1 * Update dependency Verify.Xunit to v24.1.0 * Update dependency Microsoft.Playwright to v1.43.0 (#1501) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Rebase/with master (#1508) * wip on adding async for all the new host builder style interfaces (#1495) * wip on adding async for all the new host builder style interfaces * Continued work on async changes for the new hosting patterns * Automatically linting code * working on selecting the version of .net to run * next up dealing with dependency injection * it compiles, async all the things, remove a lot of legacy * Unit tests now pass, changed around the base interface from IServiceProvider to IServiceProviderDictionary * Fixed the build failures with samples * Automatically linting code * fixed warnings * Removing a few projects that are not needed. * minor package reference change * Automatically linting code * Added types provider to assembly provider * Added initial support for generated AssemblyProvider * refined things so we have proper yield returns now! * added tests for self assembly, duplicating lines, as well as dependent assemblies * Started work on generated assembly provider, added runtime and compile time tests. Working through compile time behaviors now. * all tests now pass... onto serialization! * time to serialize * configured in place most of the json * more adjustments to assemblies provider compilation * Updated snapshots, most tests now pass! * All tests pass... * all tests pass...maybe it works... * Automatically linting code * Updated project * Updates to analyzers, now output the new format for imports and assembly providers * stuff and things * All the pass... * Updated verified files * Updated verified files * attempt to fix tests * Fixed last tests... * couple minor docs changes * warnings pass * format pass * Automatically linting code * bump in the night * Automatically linting code --------- Co-authored-by: Rocket Understudy <33589210+rsg-bot@users.noreply.github.com> * Updated gitversion config --------- Co-authored-by: Rocket Understudy <33589210+rsg-bot@users.noreply.github.com> * Revert "Rebase/with master (#1508)" (#1509) This reverts commit 456f450. * Update dependency Rocket.Surgery.Nuke to v1.8.28 * Update dependency Polyfill to v4.6.0 * wip on adding async for all the new host builder style interfaces (#1495) * wip on adding async for all the new host builder style interfaces * Continued work on async changes for the new hosting patterns * Automatically linting code * working on selecting the version of .net to run * next up dealing with dependency injection * it compiles, async all the things, remove a lot of legacy * Unit tests now pass, changed around the base interface from IServiceProvider to IServiceProviderDictionary * Fixed the build failures with samples * Automatically linting code * fixed warnings * Removing a few projects that are not needed. * minor package reference change * Automatically linting code * Added types provider to assembly provider * Added initial support for generated AssemblyProvider * refined things so we have proper yield returns now! * added tests for self assembly, duplicating lines, as well as dependent assemblies * Started work on generated assembly provider, added runtime and compile time tests. Working through compile time behaviors now. * all tests now pass... onto serialization! * time to serialize * configured in place most of the json * more adjustments to assemblies provider compilation * Updated snapshots, most tests now pass! * All tests pass... * all tests pass...maybe it works... * Automatically linting code * Updated project * Updates to analyzers, now output the new format for imports and assembly providers * stuff and things * All the pass... * Updated verified files * Updated verified files * attempt to fix tests * Fixed last tests... * couple minor docs changes * warnings pass * format pass * Automatically linting code * bump in the night * Automatically linting code --------- Co-authored-by: Rocket Understudy <33589210+rsg-bot@users.noreply.github.com> * Updated gitversion config * Rebase/with master (#1510) * Update dependency Verify.Xunit to v23.7.2 * Update dependency jetbrains.resharper.globaltools to v2024 * Update codecov/codecov-action action to v4.3.0 * Update dependency Polyfill to v4.5.0 * Update dependency FakeItEasy to v8.2.0 * Update xunit * Update dependency Verify.Xunit to v24 * Update dependency dotnet-outdated-tool to v4.6.1 * Update dependency Verify.Xunit to v24.1.0 * Update dependency Microsoft.Playwright to v1.43.0 (#1501) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Revert "Rebase/with master (#1508)" (#1509) This reverts commit 456f450. * wip on adding async for all the new host builder style interfaces (#1495) * wip on adding async for all the new host builder style interfaces * Continued work on async changes for the new hosting patterns * Automatically linting code * working on selecting the version of .net to run * next up dealing with dependency injection * it compiles, async all the things, remove a lot of legacy * Unit tests now pass, changed around the base interface from IServiceProvider to IServiceProviderDictionary * Fixed the build failures with samples * Automatically linting code * fixed warnings * Removing a few projects that are not needed. * minor package reference change * Automatically linting code * Added types provider to assembly provider * Added initial support for generated AssemblyProvider * refined things so we have proper yield returns now! * added tests for self assembly, duplicating lines, as well as dependent assemblies * Started work on generated assembly provider, added runtime and compile time tests. Working through compile time behaviors now. * all tests now pass... onto serialization! * time to serialize * configured in place most of the json * more adjustments to assemblies provider compilation * Updated snapshots, most tests now pass! * All tests pass... * all tests pass...maybe it works... * Automatically linting code * Updated project * Updates to analyzers, now output the new format for imports and assembly providers * stuff and things * All the pass... * Updated verified files * Updated verified files * attempt to fix tests * Fixed last tests... * couple minor docs changes * warnings pass * format pass * Automatically linting code * bump in the night * Automatically linting code --------- Co-authored-by: Rocket Understudy <33589210+rsg-bot@users.noreply.github.com> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Rocket Understudy <33589210+rsg-bot@users.noreply.github.com> * Feature/work with nested typeof (#1512) * Update dependency Verify.Xunit to v23.7.2 * Update dependency jetbrains.resharper.globaltools to v2024 * Update codecov/codecov-action action to v4.3.0 * Update dependency Polyfill to v4.5.0 * Update dependency FakeItEasy to v8.2.0 * Update xunit * Update dependency Verify.Xunit to v24 * Update dependency dotnet-outdated-tool to v4.6.1 * Update dependency Verify.Xunit to v24.1.0 * Update dependency Microsoft.Playwright to v1.43.0 (#1501) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Revert "Rebase/with master (#1508)" (#1509) This reverts commit 456f450. * wip on adding async for all the new host builder style interfaces (#1495) * wip on adding async for all the new host builder style interfaces * Continued work on async changes for the new hosting patterns * Automatically linting code * working on selecting the version of .net to run * next up dealing with dependency injection * it compiles, async all the things, remove a lot of legacy * Unit tests now pass, changed around the base interface from IServiceProvider to IServiceProviderDictionary * Fixed the build failures with samples * Automatically linting code * fixed warnings * Removing a few projects that are not needed. * minor package reference change * Automatically linting code * Added types provider to assembly provider * Added initial support for generated AssemblyProvider * refined things so we have proper yield returns now! * added tests for self assembly, duplicating lines, as well as dependent assemblies * Started work on generated assembly provider, added runtime and compile time tests. Working through compile time behaviors now. * all tests now pass... onto serialization! * time to serialize * configured in place most of the json * more adjustments to assemblies provider compilation * Updated snapshots, most tests now pass! * All tests pass... * all tests pass...maybe it works... * Automatically linting code * Updated project * Updates to analyzers, now output the new format for imports and assembly providers * stuff and things * All the pass... * Updated verified files * Updated verified files * attempt to fix tests * Fixed last tests... * couple minor docs changes * warnings pass * format pass * Automatically linting code * bump in the night * Automatically linting code --------- Co-authored-by: Rocket Understudy <33589210+rsg-bot@users.noreply.github.com> * Fixed typeof values using the metadata name * fixed compiler errors * pushed changes * Automatically linting code * Updated tests view * Automatically linting code * Updated tests view --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Rocket Understudy <33589210+rsg-bot@users.noreply.github.com> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Rocket Understudy <33589210+rsg-bot@users.noreply.github.com> * fixed get service call generation (#1515) * Updated gitversion (#1516) * ensure assembly load context is added to the app (#1517) * ensure assembly load context is added to the app * Added blazor conditional * Fixed missing overloads for was and simplified a few other overloads * fixed failing tests * Automatically linting code * verify changes * verify changes * Added a few fortesting methods --------- Co-authored-by: Rocket Understudy <33589210+rsg-bot@users.noreply.github.com> * Fixed static generic type scanning (#1518) * Fixed issue where attributes would not be emitted. if there were not types or assemblies found, these attributes should always be emitted regardless (#1520) * fix line numbers (#1521) * fix line numbers again? (#1522) * fix fortesting to add assembyloadcontext (#1523) * Try/fix testing environment (#1527) * Updated support for how assemblies are created * final updates to add unit test and other dependent assemblies * Automatically linting code --------- Co-authored-by: Rocket Understudy <33589210+rsg-bot@users.noreply.github.com> * is test project instead of xunit reference (#1528) * Feature/generated configuration methods (#1530) * wip on setting up generated configuration methods, so that conventions is used to create the underlying host instance, instead of first, to allow for conventions to be added throughout the lifecycle * refactor all the things for running as last item instead of anywhere in the builder * fixing failing tests * Automatically linting code * Automatically linting code --------- Co-authored-by: Rocket Understudy <33589210+rsg-bot@users.noreply.github.com> * warnings pass related to generated code (#1531) * warnings pass related to generated code * Automatically linting code --------- Co-authored-by: Rocket Understudy <33589210+rsg-bot@users.noreply.github.com> * Fix/open generic typeof (#1532) * fixed a scenario where an open generic would not get the correct number of commas! * Automatically linting code --------- Co-authored-by: Rocket Understudy <33589210+rsg-bot@users.noreply.github.com> * Feature/arne methods (#1533) * Added ArgumentNullException Helpers * try and fix other stuff that is broken in s * initial work on default program class definition if missing from source. (#1536) * initial work on default program class definition if missing from source. * handle root namespaces properly * otFeature/builder services (#1539) * added support for program generation * ensure the generated methods work as expected * final touches * fixed a generator bug * fixed a few warnings * fixed a few warnings from the generated code bit (#1540) * fixed a bug where scanning would not properly emit the assembly attributes (#1541) * Fix/program namespace (#1543) * fixed namespace for generated program * Automatically linting code * method should be async --------- Co-authored-by: Rocket Understudy <33589210+rsg-bot@users.noreply.github.com> * Modified the name of 'Program' to be a little better and more specific (#1546) * Modified the name of 'Program' to be a little better and more specific * Automatically linting code * some type cleanup --------- Co-authored-by: Rocket Understudy <33589210+rsg-bot@users.noreply.github.com> * Feature/async command line configuration (#1550) * Added support for async conventions for the command line! * move commandline to a non conventions assembly name * Automatically linting code --------- Co-authored-by: Rocket Understudy <33589210+rsg-bot@users.noreply.github.com> * bump --------- Co-authored-by: Rocket Understudy <33589210+rsg-bot@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.