Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warnings from generated code #1962

Merged
merged 2 commits into from
Dec 21, 2024
Merged

warnings from generated code #1962

merged 2 commits into from
Dec 21, 2024

Conversation

david-driscoll
Copy link
Member

No description provided.

@david-driscoll david-driscoll enabled auto-merge (squash) December 21, 2024 03:40
@github-actions github-actions bot added this to the v14.0.1 milestone Dec 21, 2024
Copy link
Contributor

github-actions bot commented Dec 21, 2024

Summary

Summary
Generated on: 12/21/2024 - 03:52:13
Coverage date: 12/21/2024 - 03:52:11
Parser: Cobertura
Assemblies: 27
Classes: 191
Files: 169
Line coverage: 59.7% (3247 of 5432)
Covered lines: 3247
Uncovered lines: 2185
Coverable lines: 5432
Total lines: 26747
Branch coverage: 49.2% (411 of 834)
Covered branches: 411
Total branches: 834
Method coverage: Feature is only available for sponsors
Tag: 14.0.1-pr1962.459+Branch.pull-1962-merge.Sha.2bbcf330214508ce7517c00b8f02d8c75c0df664

Coverage

Aspire.Hosting.Tests - 28.1%
Name Line Branch
Aspire.Hosting.Tests 28.1% 100%
Aspire.Hosting.Tests.ModuleInitializer 100% 100%
Aspire.Hosting.Tests.RocketDistributedApplicationBuilderTests 100%
Aspire.Hosting.Tests.RocketDistributedApplicationTestingBuilderTests 100%
Rocket.Surgery.Aspire.Hosting.GeneratedRocketDistributedApplicationBuilderE
xtensions
18.9%
Rocket.Surgery.Aspire.Hosting.Testing.GeneratedRocketDistributedApplication
TestingBuilderExtensions
18.9%
Rocket.Surgery.CommandLine - 36.9%
Name Line Branch
Rocket.Surgery.CommandLine 36.9% 24%
Rocket.Surgery.CommandLine.AppSettings 50% 100%
Rocket.Surgery.CommandLine.AppSettingsConfigurationProvider 5% 0%
Rocket.Surgery.CommandLine.AppSettingsConfigurationSource 66.6%
Rocket.Surgery.CommandLine.ConsoleInterceptor 16.6% 0%
Rocket.Surgery.CommandLine.ConsoleWorker 100% 66.6%
Rocket.Surgery.CommandLine.ConventionTypeRegistrar 62.9% 0%
Rocket.Surgery.CommandLine.ConventionTypeResolver 100% 66.6%
Rocket.Surgery.CommandLine.DefaultCommand 100%
Rocket.Surgery.CommandLine.FallbackServiceProvider 0% 0%
Rocket.Surgery.Conventions.CommandAppHostBuilderExtensions 8.4% 0%
Rocket.Surgery.Conventions - 81.4%
Name Line Branch
Rocket.Surgery.Conventions 81.4% 80.5%
Rocket.Surgery.Conventions.ConventionContext 82.1% 50%
Rocket.Surgery.Conventions.ConventionContextHelpers 100% 100%
Rocket.Surgery.Conventions.LoggingBuilder 0%
Rocket.Surgery.Conventions.LoggingExtensions 0%
Rocket.Surgery.Conventions.Testing.TestConventionContextBuilderExtensions 91.9% 75%
Rocket.Surgery.Conventions.Abstractions - 58.1%
Name Line Branch
Rocket.Surgery.Conventions.Abstractions 58.1% 49.2%
Rocket.Surgery.Conventions.AfterConventionAttribute 100%
Rocket.Surgery.Conventions.AfterConventionAttribute 100%
Rocket.Surgery.Conventions.BeforeConventionAttribute 100%
Rocket.Surgery.Conventions.BeforeConventionAttribute 100%
Rocket.Surgery.Conventions.Configuration.ConfigurationBuilderDelegateResult 100%
Rocket.Surgery.Conventions.Configuration.ConfigurationOptionsExtensions 62% 58.3%
Rocket.Surgery.Conventions.ConventionCategory 61.7% 21.4%
Rocket.Surgery.Conventions.ConventionCategory.ValueEqualityComparer 0% 0%
Rocket.Surgery.Conventions.ConventionCategoryAttribute 100%
Rocket.Surgery.Conventions.ConventionContextBuilder 62.9% 68.1%
Rocket.Surgery.Conventions.ConventionContextExtensions 70.8% 58.3%
Rocket.Surgery.Conventions.ConventionDependency 20% 0%
Rocket.Surgery.Conventions.ConventionHostBuilderExtensions 31.5% 18.3%
Rocket.Surgery.Conventions.ConventionHostBuilderExtensions.ServiceProviderW
rapper
100%
Rocket.Surgery.Conventions.ConventionMetadata 63.1%
Rocket.Surgery.Conventions.ConventionOrDelegate 63.3% 58.3%
Rocket.Surgery.Conventions.ConventionProvider 99.2% 97.2%
Rocket.Surgery.Conventions.ConventionsConfigurationAttribute 0%
Rocket.Surgery.Conventions.DependentOfConventionAttribute 100%
Rocket.Surgery.Conventions.DependentOfConventionAttribute 100%
Rocket.Surgery.Conventions.DependsOnConventionAttribute 100%
Rocket.Surgery.Conventions.DependsOnConventionAttribute 100%
Rocket.Surgery.Conventions.ExportedConventionsAttribute 0%
Rocket.Surgery.Conventions.IConvention 100%
Rocket.Surgery.Conventions.ImportHelpers 100% 41.6%
Rocket.Surgery.Conventions.ImportsTypeAttribute 0%
Rocket.Surgery.Conventions.LiveConventionAttribute 100%
Rocket.Surgery.Conventions.Logging.RocketLoggingOptions 100% 100%
Rocket.Surgery.Conventions.ReadOnlyServiceProviderDictionary 0% 0%
Rocket.Surgery.Conventions.ServiceProviderDictionary 42.3% 83.3%
Rocket.Surgery.Conventions.ServiceProviderDictionaryExtensions 65% 80%
Rocket.Surgery.Conventions.ThrowHelper 50% 25%
Rocket.Surgery.Conventions.UnitTestConventionAttribute 100%
Rocket.Surgery.Conventions.Analyzers - 75.2%
Name Line Branch
Rocket.Surgery.Conventions.Analyzers 75.2% 53.3%
Rocket.Surgery.Conventions.ConventionAttributeData 100%
Rocket.Surgery.Conventions.ConventionAttributesGenerator 100% 100%
Rocket.Surgery.Conventions.ConventionConfigurationData 88.4% 65.7%
Rocket.Surgery.Conventions.ConventionConfigurationData.InnerConventionConfi
gurationData
100%
Rocket.Surgery.Conventions.Diagnostics 0%
Rocket.Surgery.Conventions.Helpers 51.1% 4.1%
Rocket.Surgery.Conventions.Support.ExportConventions 93.1% 90.5%
Rocket.Surgery.Conventions.Support.ExportConventions.Request 100%
Rocket.Surgery.Conventions.Support.ImportConventions 78.1% 68.4%
Rocket.Surgery.Conventions.Support.ImportConventions.Request 100%
Rocket.Surgery.Conventions.Analyzers.Tests - 98.5%
Name Line Branch
Rocket.Surgery.Conventions.Analyzers.Tests 98.5% 100%
Rocket.Surgery.Conventions.Analyzers.Tests.ExportedConventionsGenericTests 100%
Rocket.Surgery.Conventions.Analyzers.Tests.ExportedConventionsTests 100%
Rocket.Surgery.Conventions.Analyzers.Tests.ExportedMsBuildConventionsTests 100%
Rocket.Surgery.Conventions.Analyzers.Tests.GenerationHelpers 100%
Rocket.Surgery.Conventions.Analyzers.Tests.GeneratorTest 100%
Rocket.Surgery.Conventions.Analyzers.Tests.GeneratorTestContextBuilderExten
sions
100% 100%
Rocket.Surgery.Conventions.Analyzers.Tests.GetTypesTestsData.GetTypesItem 0%
Rocket.Surgery.Conventions.Analyzers.Tests.ImportConventionsGenericTests 100%
Rocket.Surgery.Conventions.Analyzers.Tests.ImportConventionsMsBuildConfigur
ationTests
100%
Rocket.Surgery.Conventions.Analyzers.Tests.ImportConventionsMsBuildGenericC
onfigurationTests
100%
Rocket.Surgery.Conventions.Analyzers.Tests.ImportConventionsTests 100%
Rocket.Surgery.Conventions.Analyzers.Tests.ModuleInitializer 100% 100%
Rocket.Surgery.Conventions.Autofac - 55.8%
Name Line Branch
Rocket.Surgery.Conventions.Autofac 55.8% 30%
Rocket.Surgery.Conventions.Autofac.AutofacConventionServiceProviderFactory 100% 50%
Rocket.Surgery.Conventions.AutofacConventionRocketHostExtensions 44.1% 25%
Rocket.Surgery.Conventions.Configuration.Json - 100%
Name Line Branch
Rocket.Surgery.Conventions.Configuration.Json 100% 100%
Rocket.Surgery.Conventions.Configuration.Json.JsonConvention 100% 100%
Rocket.Surgery.Conventions.Configuration.Yaml - 22.6%
Name Line Branch
Rocket.Surgery.Conventions.Configuration.Yaml 22.6% 10.5%
Rocket.Surgery.Conventions.Configuration.Yaml.StaticConfigurationProvider 0% 0%
Rocket.Surgery.Conventions.Configuration.Yaml.StaticConfigurationSource 0%
Rocket.Surgery.Conventions.Configuration.Yaml.YamlConfigurationExtensions 0% 0%
Rocket.Surgery.Conventions.Configuration.Yaml.YamlConfigurationProvider 10%
Rocket.Surgery.Conventions.Configuration.Yaml.YamlConfigurationSource 100%
Rocket.Surgery.Conventions.Configuration.Yaml.YamlConfigurationStreamParser 0% 0%
Rocket.Surgery.Conventions.Configuration.Yaml.YamlConvention 100% 100%
Rocket.Surgery.Conventions.Diagnostics - 50.9%
Name Line Branch
Rocket.Surgery.Conventions.Diagnostics 50.9% 50%
Rocket.Surgery.Conventions.Diagnostics.DiagnosticLogger 61.9% 50%
Rocket.Surgery.Conventions.Diagnostics.DiagnosticLogger.Disposable 0%
Rocket.Surgery.Conventions.DryIoc - 39%
Name Line Branch
Rocket.Surgery.Conventions.DryIoc 39% 38.8%
Rocket.Surgery.Conventions.DryIoc.DryIocConventionServiceProviderFactory 100% 75%
Rocket.Surgery.Conventions.DryIoc.DryIocOptions 100%
Rocket.Surgery.Conventions.DryIocConventionRocketHostExtensions 31.1% 28.5%
Rocket.Surgery.Conventions.Tests - 93.5%
Name Line Branch
Rocket.Surgery.Conventions.Tests 93.5% 60.6%
Rocket.Surgery.Conventions.Analyzers.Tests.GetTypesTestsData.GetTypesItem 0%
Rocket.Surgery.Conventions.Tests.Contrib 100%
Rocket.Surgery.Conventions.Tests.ConventionContextExtensionsTests 100%
Rocket.Surgery.Conventions.Tests.ConventionContextTests 100% 100%
Rocket.Surgery.Conventions.Tests.ConventionContextTests.AbcConvention 100%
Rocket.Surgery.Conventions.Tests.ConventionContextTests.InjectableConventio
n
100%
Rocket.Surgery.Conventions.Tests.ConventionContextTests.OptionalInjectableC
onvention
100% 100%
Rocket.Surgery.Conventions.Tests.ConventionProviderTests 66.6% 66.6%
Rocket.Surgery.Conventions.Tests.ConventionProviderTests.C 0%
Rocket.Surgery.Conventions.Tests.ConventionProviderTests.D 0%
Rocket.Surgery.Conventions.Tests.ConventionScannerTests 100% 100%
Rocket.Surgery.Conventions.Tests.ConventionStaticScannerTests 100% 100%
Rocket.Surgery.Conventions.Tests.ConventionTests 0%
Rocket.Surgery.Conventions.Tests.DiagnosticLoggerTests 100%
Rocket.Surgery.Conventions.Tests.GenericTypedConventionProviderTests 73.3% 100%
Rocket.Surgery.Conventions.Tests.GenericTypedConventionProviderTests.C 0%
Rocket.Surgery.Conventions.Tests.GenericTypedConventionProviderTests.D 0%
Rocket.Surgery.Conventions.Tests.GenericTypedConventionScannerTests 100% 100%
Rocket.Surgery.Conventions.Tests.ModuleInitializer 69.2% 33.3%
Rocket.Surgery.Conventions.Tests.ModuleInitializer.AssemblyConverter 0%
Rocket.Surgery.Conventions.Tests.ModuleInitializer.TypeConverter 0% 0%
Rocket.Surgery.Conventions.Tests.ServiceProviderDictionaryExtensionsTests 100%
Rocket.Surgery.Conventions.Tests.StaticConventionTests 100%
Rocket.Surgery.Conventions.Tests.TestContextTests 100% 100%
Rocket.Surgery.Conventions.Tests.TestContextTests_DependencyContext 100% 100%
Rocket.Surgery.Extensions.Autofac.Tests - 35.4%
Name Line Branch
Rocket.Surgery.Extensions.Autofac.Tests 35.4% 100%
Rocket.Surgery.Extensions.Autofac.Tests.AppExtensions 100%
Rocket.Surgery.Extensions.Autofac.Tests.AutofacBuilderTests 100%
Rocket.Surgery.Extensions.Autofac.Tests.AutofacCommandLineTests 100%
Rocket.Surgery.Extensions.Autofac.Tests.AutofacFixtures.AbcConvention 100%
Rocket.Surgery.Extensions.Autofac.Tests.AutofacFixtures.OtherConvention 100%
Rocket.Surgery.Extensions.Autofac.Tests.AutofacWebApplicationTests 100%
Rocket.Surgery.Extensions.Autofac.Tests.LoggingBuilder 0%
Rocket.Surgery.Extensions.Autofac.Tests.ModuleInitializer 100% 100%
Rocket.Surgery.Hosting.GeneratedRocketHostApplicationBuilderExtensions 18.9%
Rocket.Surgery.Hosting.GeneratedRocketWebApplicationBuilderExtensions 18.9%
Rocket.Surgery.Extensions.CommandLine.Tests - 30.4%
Name Line Branch
Rocket.Surgery.Extensions.CommandLine.Tests 30.4% 33.3%
Rocket.Surgery.Extensions.CommandLine.Tests.CommandLineBuilderTests 54.7% 33.3%
Rocket.Surgery.Extensions.CommandLine.Tests.CommandLineBuilderTests.Add 0%
Rocket.Surgery.Extensions.CommandLine.Tests.CommandLineBuilderTests.Command
WithValues
37.5%
Rocket.Surgery.Extensions.CommandLine.Tests.CommandLineBuilderTests.Injecti
onConstructor
100%
Rocket.Surgery.Extensions.CommandLine.Tests.CommandLineBuilderTests.LoggerI
njection
100%
Rocket.Surgery.Extensions.CommandLine.Tests.CommandLineBuilderTests.Origin 0%
Rocket.Surgery.Extensions.CommandLine.Tests.CommandLineBuilderTests.Service
Injection
0% 0%
Rocket.Surgery.Extensions.CommandLine.Tests.CommandLineBuilderTests.Service
Injection2
0% 0%
Rocket.Surgery.Extensions.CommandLine.Tests.CommandLineBuilderTests.SubCmd 0%
Rocket.Surgery.Extensions.CommandLine.Tests.ModuleInitializer 100% 100%
Rocket.Surgery.Hosting.GeneratedRocketHostApplicationBuilderExtensions 0%
Rocket.Surgery.Extensions.DryIoc.Tests - 36.4%
Name Line Branch
Rocket.Surgery.Extensions.DryIoc.Tests 36.4% 100%
Rocket.Surgery.Extensions.DryIoc.Tests.AppExtensions 100%
Rocket.Surgery.Extensions.DryIoc.Tests.DryIocBuilderTests 100%
Rocket.Surgery.Extensions.DryIoc.Tests.DryIocCommandLineTests 100%
Rocket.Surgery.Extensions.DryIoc.Tests.DryIocFixtures.AbcConvention 100%
Rocket.Surgery.Extensions.DryIoc.Tests.DryIocFixtures.OtherConvention 100%
Rocket.Surgery.Extensions.DryIoc.Tests.DryIocWebApplicationTests 100%
Rocket.Surgery.Extensions.DryIoc.Tests.LoggingBuilder 0%
Rocket.Surgery.Extensions.DryIoc.Tests.ModuleInitializer 100% 100%
Rocket.Surgery.Hosting.GeneratedRocketHostApplicationBuilderExtensions 18.9%
Rocket.Surgery.Hosting.GeneratedRocketWebApplicationBuilderExtensions 18.9%
Rocket.Surgery.Hosting - 42.5%
Name Line Branch
Rocket.Surgery.Hosting 42.5% 33.3%
Rocket.Surgery.Conventions.HostingConventionExtensions 17.2%
Rocket.Surgery.Hosting.RocketBooster 57.1%
Rocket.Surgery.Hosting.RocketHostApplicationExtensions 100% 33.3%
Rocket.Surgery.Hosting.AspNetCore.Tests - 32.2%
Name Line Branch
Rocket.Surgery.Hosting.AspNetCore.Tests 32.2% 100%
Rocket.Surgery.Hosting.AspNetCore.Tests.ModuleInitializer 100% 100%
Rocket.Surgery.Hosting.AspNetCore.Tests.RocketWebApplicationBuilderTests 100%
Rocket.Surgery.Hosting.AspNetCore.Tests.RocketWebApplicationTests 100%
Rocket.Surgery.Hosting.AspNetCore.Tests.Startups.SimpleStartup 71.4% 100%
Rocket.Surgery.Hosting.AspNetCore.Tests.Startups.TestStartup 100% 100%
Rocket.Surgery.Hosting.GeneratedRocketHostApplicationBuilderExtensions 0%
Rocket.Surgery.Hosting.GeneratedRocketWebApplicationBuilderExtensions 37.8%
Rocket.Surgery.Hosting.Tests - 39.1%
Name Line Branch
Rocket.Surgery.Hosting.Tests 39.1% 100%
Rocket.Surgery.Hosting.GeneratedRocketHostApplicationBuilderExtensions 24.3%
Rocket.Surgery.Hosting.Tests.ModuleInitializer 100% 100%
Rocket.Surgery.Hosting.Tests.RocketHostBuilderTests 100%
Rocket.Surgery.WebAssembly.Hosting.Tests - 56.1%
Name Line Branch
Rocket.Surgery.WebAssembly.Hosting.Tests 56.1% 44.1%
Rocket.Surgery.WebAssembly.Hosting.GeneratedRocketWebAssemblyHostBuilderExt
ensions
0%
Rocket.Surgery.WebAssembly.Hosting.Tests.DevServer.DevHostServerProgram 62.7% 50%
Rocket.Surgery.WebAssembly.Hosting.Tests.ModuleInitializer 100% 100%
Rocket.Surgery.WebAssembly.Hosting.Tests.PlaywrightFixture 73.2% 37.5%
Rocket.Surgery.WebAssembly.Hosting.Tests.PlaywrightFixture.StaticSiteStartu
p
0% 0%
Rocket.Surgery.WebAssembly.Hosting.Tests.PlaywrightSampleTest 100%
Sample - 6.1%
Name Line Branch
Sample 6.1% 0%
Rocket.Surgery.Hosting.GeneratedRocketHostApplicationBuilderExtensions 0%
Sample.DefaultCommand 0%
Sample.Dump 20% 0%
Sample.Dump.DumpConvention 100%
Sample.BlazorWasm - 0%
Name Line Branch
Sample.BlazorWasm 0% 0%
Rocket.Surgery.WebAssembly.Hosting.GeneratedRocketWebAssemblyHostBuilderExt
ensions
0%
Sample.BlazorWasm.Pages.Counter 0%
Sample.BlazorWasm.Pages.FetchData 0% 0%
Sample.BlazorWasm.Pages.FetchData.WeatherForecast 0%
Sample.BlazorWasm.Shared.NavMenu 0% 0%
Sample.Core - 46.3%
Name Line Branch
Sample.Core 46.3% 16.6%
Sample.Core.AService 0%
Sample.Core.CoreConvention 100%
Sample.Core.Databases.DatabaseConfigurator 25%
Sample.Core.Databases.DatabaseConfiguratorExtensions 44.4% 16.6%
Sample.Core.Databases.DatabaseConventionContextBuilderExtensions 0%
Sample.Core.Databases.DatabaseServiceConvention 100%
Sample.Core.TestConvention 100%
Sample.Core.TestService 100%
Sample.Core.Tests - 0%
Name Line Branch
Sample.Core.Tests 0% ****
Sample.Core.Tests.SampleTests 0%
Sample.DependencyOne - 0%
Name Line Branch
Sample.DependencyOne 0% ****
Sample.DependencyOne.Example1.Request 0%
Sample.DependencyOne.Example1.Validator 0%
Sample.DependencyThree - 0%
Name Line Branch
Sample.DependencyThree 0% ****
Sample.DependencyThree.Example3.Request 0%
Sample.DependencyThree.Example3.Validator 0%
Sample.DependencyTwo - 0%
Name Line Branch
Sample.DependencyTwo 0% ****
Sample.DependencyTwo.Example2.Request 0%
Sample.DependencyTwo.Example2.Validator 0%
Sample.Tests - 5.1%
Name Line Branch
Sample.Tests 5.1% ****
Rocket.Surgery.Hosting.GeneratedRocketHostApplicationBuilderExtensions 0%
Sample.Tests.SampleTestHostTests 100%

Copy link
Contributor

Test Results

 23 files  ±0   23 suites  ±0   10m 57s ⏱️ -11s
334 tests ±0  333 ✅ ±0  1 💤 ±0  0 ❌ ±0 
819 runs  ±0  817 ✅ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit f52eeaa. ± Comparison against base commit 2db65e3.

@david-driscoll david-driscoll merged commit 46acab3 into master Dec 21, 2024
8 checks passed
@david-driscoll david-driscoll deleted the fix/more-warnings branch December 21, 2024 03:52
Copy link

codecov bot commented Dec 21, 2024

Codecov Report

Attention: Patch coverage is 69.23077% with 4 lines in your changes missing coverage. Please review.

Project coverage is 69.77%. Comparing base (2db65e3) to head (f52eeaa).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...Conventions.Analyzers/Support/ImportConventions.cs 69.23% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1962      +/-   ##
==========================================
+ Coverage   62.94%   69.77%   +6.82%     
==========================================
  Files         139      139              
  Lines        4755     4294     -461     
  Branches      269      269              
==========================================
+ Hits         2993     2996       +3     
+ Misses       1710     1246     -464     
  Partials       52       52              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the ✨ mysterious We forgot to label this label Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ mysterious We forgot to label this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants