Updated the default versions for the github actions to the latest

src/Nuke/GithubActions/CheckoutStep.cs

@@ -11,7 +11,7 @@
     /// <param name="name"></param>
     public CheckoutStep(string name) : base(name)
     {
-        Uses = "actions/checkout@v2";
+        Uses = "actions/checkout@v4";
     }
 
     /// <summary>
@@ -121,9 +121,9 @@
     /// <inheritdoc />
     public override void Write(CustomFileWriter writer)
     {
-#pragma warning disable CA1308
+        #pragma warning disable CA1308
         WithProperties(x => x.Underscore().Hyphenate().ToLowerInvariant());
-#pragma warning restore CA1308
+        #pragma warning restore CA1308
         base.Write(writer);
     }
-}
+}

src/Nuke/GithubActions/DownloadArtifactSet.cs

@@ -11,7 +11,7 @@
     /// <param name="name"></param>
     public DownloadArtifactSet(string name) : base(name)
     {
-        Uses = "actions/download-artifact@v1";
+        Uses = "actions/download-artifact@v3";
     }
 
     /// <summary>
@@ -27,9 +27,9 @@
     /// <inheritdoc />
     public override void Write(CustomFileWriter writer)
     {
-#pragma warning disable CA1308
+        #pragma warning disable CA1308
         WithProperties(x => x.Underscore().Camelize().ToLowerInvariant());
-#pragma warning restore CA1308
+        #pragma warning restore CA1308
         base.Write(writer);
     }
 
@@ -38,4 +38,4 @@
     {
         return $"🚀 {name}";
     }
-}
+}

src/Nuke/GithubActions/GithubActionsExtensions.cs

@@ -20,58 +20,39 @@
     /// <returns></returns>
     public static RocketSurgeonGitHubActionsConfiguration AddNugetPublish(this RocketSurgeonGitHubActionsConfiguration configuration)
     {
-        configuration.DetailedTriggers.OfType<RocketSurgeonGitHubActionsWorkflowTrigger>().ForEach(
-            trigger =>
-            {
-                trigger.Secrets.Add(new GitHubActionsSecret("RSG_NUGET_API_KEY"));
-                trigger.Secrets.Add(new GitHubActionsSecret("RSG_AZURE_DEVOPS"));
-            }
-        );
+        configuration
+           .DetailedTriggers.OfType<RocketSurgeonGitHubActionsWorkflowTrigger>()
+           .ForEach(
+                trigger =>
+                {
+                    trigger.Secrets.Add(new("RSG_NUGET_API_KEY"));
+                    trigger.Secrets.Add(new("RSG_AZURE_DEVOPS"));
+                }
+            );
         configuration.Jobs.Add(
             new RocketSurgeonsGithubWorkflowJob("Publish")
             {
-                Needs = { "Build" },
+                Needs = { "Build", },
                 Uses = "RocketSurgeonsGuild/actions/.github/workflows/publish-nuget.yml@v0.3.0",
-                Secrets = new Dictionary<string, string>
-                {
-                    ["RSG_NUGET_API_KEY"] = "${{ secrets.RSG_NUGET_API_KEY }}",
-                    ["RSG_AZURE_DEVOPS"] = "${{ secrets.RSG_AZURE_DEVOPS }}",
-                }
+                Secrets = new()
+                          {
+                              ["RSG_NUGET_API_KEY"] = "${{ secrets.RSG_NUGET_API_KEY }}",
+                              ["RSG_AZURE_DEVOPS"] = "${{ secrets.RSG_AZURE_DEVOPS }}",
+                          },
             }
         );
         return configuration;
     }
 
-    private static readonly string[] _pathsIgnore =
-    {
-        ".codecov.yml",
-        ".editorconfig",
-        ".gitattributes",
-        ".gitignore",
-        ".gitmodules",
-        ".lintstagedrc.js",
-        ".prettierignore",
-        ".prettierrc",
-        "LICENSE",
-        "nukeeper.settings.json",
-        "omnisharp.json",
-        "package-lock.json",
-        "package.json",
-        "Readme.md",
-        ".github/dependabot.yml",
-        ".github/labels.yml",
-        ".github/release.yml",
-        ".github/renovate.json",
-    };
-
     /// <summary>
     ///     Adds a new step to the current configuration
     /// </summary>
     /// <param name="configuration"></param>
     /// <param name="job"></param>
     /// <returns></returns>
     public static RocketSurgeonGitHubActionsConfiguration AddJob(
-        this RocketSurgeonGitHubActionsConfiguration configuration, RocketSurgeonsGithubActionsJobBase job
+        this RocketSurgeonGitHubActionsConfiguration configuration,
+        RocketSurgeonsGithubActionsJobBase job
     )
     {
         configuration.Jobs.Add(job);
@@ -171,15 +152,15 @@
         job.InsertAfterCheckOut(
             new UsingStep("NuGet Cache")
             {
-                Uses = "actions/cache@v2",
+                Uses = "actions/cache@v3",
                 With =
                 {
                     ["path"] = "${{ github.workspace }}/.nuget/packages",
                     // keep in mind using central package versioning here
                     ["key"] = "${{ runner.os }}-nuget-${{ hashFiles('**/Directory.Packages.props') }}-${{ hashFiles('**/Directory.Packages.support.props') }}",
                     ["restore-keys"] = @"|
-              ${{ runner.os }}-nuget-"
-                }
+              ${{ runner.os }}-nuget-",
+                },
             }
         );
         return job;
@@ -192,7 +173,7 @@
     /// <returns></returns>
     public static RocketSurgeonsGithubActionsJob ConfigureForGitVersion(this RocketSurgeonsGithubActionsJob job)
     {
-        job.InsertAfterCheckOut(new RunStep("Fetch all history for all tags and branches") { Run = "git fetch --prune" });
+        job.InsertAfterCheckOut(new RunStep("Fetch all history for all tags and branches") { Run = "git fetch --prune", });
         return job;
     }
 
@@ -213,7 +194,7 @@
                 {
                     Name = "nuget",
                     Path = "artifacts/nuget/",
-                    If = "always()"
+                    If = "always()",
                 }
             );
             job.InternalData[typeof(IHaveNuGetPackages)] = true;
@@ -251,7 +232,7 @@
                 {
                     Name = "coverage",
                     Path = "coverage/",
-                    If = "always()"
+                    If = "always()",
                 }
             );
 
@@ -261,10 +242,10 @@
                     job,
                     new UsingStep("Publish Coverage")
                     {
-                        Uses = "codecov/codecov-action@v1",
+                        Uses = "codecov/codecov-action@v3",
                         If =
                             "(github.event_name != 'pull_request' && github.event_name != 'pull_request_target') || ((github.event_name == 'pull_request' || github.event_name == 'pull_request_target') && github.event.pull_request.user.login != 'renovate[bot]' && github.event.pull_request.user.login != 'dependabot[bot]')",
-                        With = new() { ["name"] = "actions-${{ matrix.os }}" }
+                        With = new() { ["name"] = "actions-${{ matrix.os }}", },
                     }
                 );
             }
@@ -278,7 +259,7 @@
                 {
                     Name = "logs",
                     Path = "artifacts/logs/",
-                    If = "always()"
+                    If = "always()",
                 }
             );
         }
@@ -291,7 +272,7 @@
                 {
                     Name = "test data",
                     Path = "artifacts/test/",
-                    If = "always()"
+                    If = "always()",
                 }
             );
         }
@@ -345,31 +326,10 @@
     public static RocketSurgeonsGithubActionsJob UseDotNetSdk(this RocketSurgeonsGithubActionsJob job, string version, string? exactVersion = null)
     {
         exactVersion ??= version + ".x";
-        job.InsertAfterCheckOut(new SetupDotNetStep($"Use .NET Core {version} SDK") { DotNetVersion = exactVersion });
+        job.InsertAfterCheckOut(new SetupDotNetStep($"Use .NET Core {version} SDK") { DotNetVersion = exactVersion, });
         return job;
     }
 
-    private static readonly ConcurrentDictionary<ITargetDefinition, List<GitHubActionsOutput>> outputPaths = new();
-
-    // ReSharper disable once NullableWarningSuppressionIsUsed
-    private static readonly PropertyInfo DefinitionProperty =
-        typeof(ExecutableTarget).GetProperty("Definition", BindingFlags.Instance | BindingFlags.NonPublic)!;
-
-
-    internal static List<GitHubActionsOutput> GetGithubActionsOutput(ExecutableTarget target)
-    {
-        // ReSharper disable once NullableWarningSuppressionIsUsed
-        var def = (ITargetDefinition)DefinitionProperty.GetValue(target)!;
-        if (outputPaths.TryGetValue(def, out var paths))
-        {
-            return paths;
-        }
-
-        paths = new();
-        outputPaths[def] = paths;
-        return paths;
-    }
-
     /// <summary>
     ///     Set an output for github actions
     /// </summary>
@@ -399,7 +359,50 @@
             outputPaths[target] = paths;
         }
 
-        paths.Add(new GitHubActionsOutput(outputName, description));
+        paths.Add(new(outputName, description));
         return target;
     }
-}
+
+
+    internal static List<GitHubActionsOutput> GetGithubActionsOutput(ExecutableTarget target)
+    {
+        // ReSharper disable once NullableWarningSuppressionIsUsed
+        var def = (ITargetDefinition)DefinitionProperty.GetValue(target)!;
+        if (outputPaths.TryGetValue(def, out var paths))
+        {
+            return paths;
+        }
+
+        paths = new();
+        outputPaths[def] = paths;
+        return paths;
+    }
+
+    private static readonly string[] _pathsIgnore =
+    {
+        ".codecov.yml",
+        ".editorconfig",
+        ".gitattributes",
+        ".gitignore",
+        ".gitmodules",
+        ".lintstagedrc.js",
+        ".prettierignore",
+        ".prettierrc",
+        "LICENSE",
+        "nukeeper.settings.json",
+        "omnisharp.json",
+        "package-lock.json",
+        "package.json",
+        "Readme.md",
+        ".github/dependabot.yml",
+        ".github/labels.yml",
+        ".github/release.yml",
+        ".github/renovate.json",
+    };
+
+    private static readonly ConcurrentDictionary<ITargetDefinition, List<GitHubActionsOutput>> outputPaths = new();
+
+    // ReSharper disable once NullableWarningSuppressionIsUsed
+    private static readonly PropertyInfo DefinitionProperty =
+        typeof(ExecutableTarget).GetProperty("Definition", BindingFlags.Instance | BindingFlags.NonPublic)!;
+}

src/Nuke/GithubActions/SetupDotNetStep.cs

@@ -14,7 +14,7 @@
     public SetupDotNetStep(string name) : base(name)
     {
         // temporary to deal with sxs issue roll back once https://github.com/actions/setup-dotnet/pull/71 is merged
-        Uses = "actions/setup-dotnet@v1";
+        Uses = "actions/setup-dotnet@v3";
     }
 
     /// <summary>SDK version to use. Example: 2.2.104</summary>
@@ -76,4 +76,4 @@
 
         base.Write(writer);
     }
-}
+}

src/Nuke/GithubActions/UploadArtifactStep.cs

@@ -11,7 +11,7 @@
     /// <param name="name"></param>
     public UploadArtifactStep(string name) : base(name)
     {
-        Uses = "actions/upload-artifact@v2";
+        Uses = "actions/upload-artifact@v3";
     }
 
     /// <summary>
@@ -27,9 +27,9 @@
     /// <inheritdoc />
     public override void Write(CustomFileWriter writer)
     {
-#pragma warning disable CA1308
+        #pragma warning disable CA1308
         WithProperties(x => x.Underscore().Camelize().ToLowerInvariant());
-#pragma warning restore CA1308
+        #pragma warning restore CA1308
         base.Write(writer);
     }
 
@@ -38,4 +38,4 @@
     {
         return $"🏺 {name}";
     }
-}
+}

src/Nuke/ICanRegenerateBuildConfiguration.cs

@@ -13,35 +13,32 @@
     /// <summary>
     ///     Regenerate the build configurations
     /// </summary>
-    public Target RegenerateBuildConfigurations => t =>
-                                                       t
-                                                          .TryDependentFor<ICanLintStagedFiles>(static z => z.LintStaged)
-                                                          .TryTriggeredBy<ICanLint>(static z => z.Lint)
-                                                           // We run during LintStaged, no need to run again during the lint that lint-staged kicks off.
-                                                          .OnlyWhenDynamic(() => !EnvironmentInfo.HasVariable("RSG_NUKE_LINT_STAGED"))
-                                                          .Unlisted()
-                                                          .Executes(
-                                                               () =>
-                                                               {
-                                                                   var allHosts = GetType()
-                                                                                 .GetCustomAttributes<ConfigurationAttributeBase>()
-                                                                                 .OfType<IConfigurationGenerator>();
+    public Target RegenerateBuildConfigurations =>
+        t => t
+            .TryDependentFor<ICanLintStagedFiles>(static z => z.LintStaged)
+            .TryTriggeredBy<ICanLint>(static z => z.Lint)
+             // We run during LintStaged, no need to run again during the lint that lint-staged kicks off.
+            .OnlyWhenDynamic(() => !EnvironmentInfo.HasVariable("RSG_NUKE_LINT_STAGED"))
+            .Unlisted()
+            .Executes(
+                 () =>
+                 {
+                     var allHosts = GetType()
+                                   .GetCustomAttributes<ConfigurationAttributeBase>()
+                                   .OfType<IConfigurationGenerator>();
 
-                                                                   allHosts
-                                                                       // ReSharper disable once NullableWarningSuppressionIsUsed
-                                                                      .Select(
-                                                                           z =>
-                                                                               $"""{Assembly.GetEntryAssembly()!.Location} --{BuildServerConfigurationGeneration.ConfigurationParameterName} {z.Id} --host {z.HostName}"""
-                                                                       )
-                                                                      .ForEach(
-                                                                           command => DotNetTasks.DotNet(
-                                                                               command,
-                                                                               environmentVariables: EnvironmentInfo.Variables.AddIfMissing(
-                                                                                   "NUKE_INTERNAL_INTERCEPTOR",
-                                                                                   "1"
-                                                                               )
-                                                                           )
-                                                                       );
-                                                               }
-                                                           );
-}
+                     allHosts
+                        .Select(
+                             z =>
+                                 // ReSharper disable once NullableWarningSuppressionIsUsed
+                                 $"""{Assembly.GetEntryAssembly()!.Location} --{BuildServerConfigurationGeneration.ConfigurationParameterName} {z.Id} --host {z.HostName}"""
+                         )
+                        .ForEach(
+                             command => DotNetTasks.DotNet(
+                                 command,
+                                 environmentVariables: EnvironmentInfo.Variables.AddIfMissing("NUKE_INTERNAL_INTERCEPTOR", "1")
+                             )
+                         );
+                 }
+             );
+}