Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the runsettings file is truncated instead of just opened in th… #992

Merged
merged 3 commits into from
Nov 16, 2023

Conversation

david-driscoll
Copy link
Member

…e case the contents of the file have changed (and gotten shorter...)

…e case the contents of the file have changed (and gotten shorter...)
@david-driscoll david-driscoll enabled auto-merge (squash) November 15, 2023 23:57
@github-actions github-actions bot added this to the v1.7.5 milestone Nov 15, 2023
…ctory, cleaning etc.) into extension methods

* Added net8.0 runtime for report generator and gitversion
* Ensure runsettings overwrites correctly.
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 179 lines in your changes are missing coverage. Please review.

Comparison is base (d489639) 7.38% compared to head (7bd16f8) 7.66%.
Report is 1 commits behind head on master.

Files Patch % Lines
src/Nuke/TestMethodExtensions.cs 0.00% 50 Missing ⚠️
src/Nuke/DotNetCore/ICanTestWithDotNetCore.cs 0.00% 29 Missing ⚠️
src/Nuke/DotNetCore/ICanTestWithDotNetCoreBuild.cs 0.00% 28 Missing ⚠️
src/Nuke/ITriggerCodeCoverageReports.cs 0.00% 27 Missing ⚠️
src/Nuke/Xamarin/ICanTestXamarin.cs 0.00% 20 Missing ⚠️
src/Nuke/FilePathExtensions.cs 43.47% 13 Missing ⚠️
src/Nuke/Extensions.cs 16.66% 5 Missing ⚠️
src/Nuke/IComprehendTests.cs 16.66% 5 Missing ⚠️
src/Nuke/IHaveGitRepository.cs 0.00% 1 Missing ⚠️
src/Nuke/IHaveGitVersion.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master    #992      +/-   ##
=========================================
+ Coverage    7.38%   7.66%   +0.27%     
=========================================
  Files         125     128       +3     
  Lines        3060    3080      +20     
  Branches      215     225      +10     
=========================================
+ Hits          226     236      +10     
- Misses       2834    2844      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@david-driscoll david-driscoll merged commit 90e43d8 into master Nov 16, 2023
8 of 9 checks passed
@github-actions github-actions bot added the ✨ mysterious We forgot to label this label Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ mysterious We forgot to label this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant