Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding keyspace_hits and keyspace_misses from Redis INFO stats #45

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

allan-meng
Copy link
Contributor

@allan-meng allan-meng commented Nov 6, 2024

Looking to add keyspace_hits and keyspace_misses from Redis INFO stats.

Testing:

  1. Started local kvrocks Docker container
    docker run -it -p 6666:6666 apache/kvrocks --bind 0.0.0.0
  2. Started kvrocks_exporter
    ./kvrocks_exporter -kvrocks.addr kvrocks://localhost:6666
  3. Set up redis-cli, added some keys, issued some GETs (some hits some misses)
    redis-cli -p 6666
  4. Verified that keyspace_hits and keyspace_misses are reflected accurately in http://localhost:9121/metrics
# HELP kvrocks_keyspace_hits keyspace_hits metric
# TYPE kvrocks_keyspace_hits gauge
kvrocks_keyspace_hits 9
# HELP kvrocks_keyspace_misses keyspace_misses metric
# TYPE kvrocks_keyspace_misses gauge
kvrocks_keyspace_misses 3

@allan-meng
Copy link
Contributor Author

@git-hulk Gentle nudge, just wanted to add some additional Redis INFO metrics.

@git-hulk
Copy link
Member

git-hulk commented Nov 8, 2024

@allan-meng Thank you!

@git-hulk git-hulk merged commit 8e14bb0 into RocksLabs:master Nov 8, 2024
@allan-meng
Copy link
Contributor Author

@git-hulk Thank you for approving and merging this! I know it is a small change, but would it be possible to cut a minor release?

@git-hulk
Copy link
Member

git-hulk commented Nov 9, 2024

@allan-meng Sure, v1.0.5 is ready to use now. Thanks for your contribution again.

@allan-meng
Copy link
Contributor Author

Thank you!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants