Added distance
#67
Merged
Added distance
#67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Also added `CIVector` default conformance to `DualTwoDimensional` - Also added `magnitude` to `DualTwoDimensional`s where the `Length`s match and the distance can be determined. This was done for `CIVector` as sugar for its `.distance` between its two points - Improved description of how `Rectangle`'s `DualTwoDimensional` conformance needs both `Length`s to be the same. Thankfully didn't need to remove the `associatedtype Length` - Added an "Easy To Adopt" section to the README, inspired by this new `.distance` API
KyLeggiero
commented
Nov 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CIVectordefault conformance toDualTwoDimensionalmagnitudetoDualTwoDimensionals where theLengths match and the distance can be determined. This was done forCIVectoras sugar for its.distancebetween its two pointsRectangle'sDualTwoDimensionalconformance needs bothLengths to be the same. Thankfully didn't need to remove theassociatedtype Length.distanceAPI