Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Major, Minor, Patch, & Pre-Release identifiers doesn't behave per spec: these numeric identifiers MUST NOT include leading zeroes. #14

Closed
KyLeggiero opened this issue Apr 25, 2020 · 1 comment
Closed

Major, Minor, Patch, & Pre-Release identifiers doesn't behave per spec: these numeric identifiers MUST NOT include leading zeroes. #14

KyLeggiero opened this issue Apr 25, 2020 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@KyLeggiero
Copy link
Collaborator

KyLeggiero commented Apr 25, 2020 •
edited
Loading

According to the spec:

Numeric identifiers MUST NOT include leading zeroes.

However, SemVer(1,0,0, preRelease: "01") and SemVer("01.02.03") are allowed; it should result in nil, but instead it initializes just fine.

When fixing, this restriction should also apply to mutating the pre-release.
@KyLeggiero KyLeggiero added bug Something isn't working good first issue Good for newcomers labels Apr 25, 2020
@KyLeggiero KyLeggiero changed the title Pre-release doesn't behave per spec: numeric identifiers MUST NOT include leading zeroes. Major, Minor, Patch, & Pre-Release identifiers doesn't behave per spec: these numeric identifiers MUST NOT include leading zeroes. Oct 11, 2021
KyLeggiero added a commit that referenced this issue Oct 11, 2021
@KyLeggiero
#14: Addressed leading zeroes being invalid
57e0a43
@KyLeggiero KyLeggiero mentioned this issue Oct 11, 2021
Merged
@KyLeggiero
Copy link
Collaborator Author

Fixed with #22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KyLeggiero