Allow setting referrer in a page download #13
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what I did for #12. It's not that elegant, but it worked. I would say that expanding the API that's input to the download method makes more sense to me than overriding that method in subclasses of Scraper - what if I need a different referrer for each page? The referrer is naturally a property of the page that's being downloaded, not the scraper. So to handle more general settings, expanding the QueryBuilder seems like the right way to go. Maybe creating a new user-facing class like PageSpec, or something, would be appropriate.