fix(Breadcrumbs): Resolve strict null errors

Royal-Navy · Feb 8, 2022 · bef0bd2 · bef0bd2
1 parent d450510
commit bef0bd2
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/packages/react-component-library/src/components/Breadcrumbs/Breadcrumbs.test.tsx b/packages/react-component-library/src/components/Breadcrumbs/Breadcrumbs.test.tsx
@@ -146,4 +146,8 @@ describe('Breadcrumbs', () => {
       expect(wrapper.queryByText('Home')).toHaveAttribute('href', '#home')
     })
   })
+
+  it('does not throw an error if there are no children', () => {
+    expect(() => render(<Breadcrumbs />)).not.toThrowError()
+  })
 })
diff --git a/packages/react-component-library/src/components/Breadcrumbs/Breadcrumbs.tsx b/packages/react-component-library/src/components/Breadcrumbs/Breadcrumbs.tsx
@@ -10,7 +10,7 @@ export const Breadcrumbs: React.FC<Nav<BreadcrumbsItemProps>> = ({
   ...rest
 }) => {
   const mapped = React.Children.map(
-    children,
+    children ?? [],
     (child: React.ReactElement<BreadcrumbsItemProps>, index: number) => {
       warnIfOverwriting(child.props, 'isFirst', BreadcrumbsItem.name)
       warnIfOverwriting(child.props, 'isLast', BreadcrumbsItem.name)

diff --git a/packages/react-component-library/src/components/Breadcrumbs/BreadcrumbsItem.tsx b/packages/react-component-library/src/components/Breadcrumbs/BreadcrumbsItem.tsx
@@ -57,7 +57,7 @@ function getText(
 
 export const BreadcrumbsItem: React.FC<BreadcrumbsItemProps> = ({
   isFirst,
-  isLast,
+  isLast = false,
   link,
   href,
   children,