Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(IconLibrary): Add chain and chain-break icons. Closes #1319 and #1188 #1456

Merged
merged 1 commit into from
Sep 23, 2020

Conversation

hxltrhuxze
Copy link
Contributor

Adds new icons chain and chain-break.
Screenshot 2020-09-21 at 12 12 07

As I've also reworked how the svg icons work in Sketch, this PR also fixes the incorrectly sized home icon

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 8589 lines exceeds the maximum allowed for the inline comments feature.

@m7kvqbe1
Copy link
Collaborator

m7kvqbe1 commented Sep 21, 2020

Looks like this is missing as part of this PR:

https://github.com/Royal-Navy/design-system/blob/master/packages/icon-library/src/assets/icons/standards/loader.svg

It's causing some component library tests for fail for ProgressIndicator component.

@m7kvqbe1 m7kvqbe1 self-requested a review September 21, 2020 11:25
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 8589 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 8553 lines exceeds the maximum allowed for the inline comments feature.

@codecov
Copy link

codecov bot commented Sep 21, 2020

Codecov Report

Merging #1456 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1456   +/-   ##
=======================================
  Coverage   98.37%   98.37%           
=======================================
  Files         167      167           
  Lines        1661     1661           
  Branches      404      404           
=======================================
  Hits         1634     1634           
  Misses         27       27           

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 8553 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 8553 lines exceeds the maximum allowed for the inline comments feature.

@m7kvqbe1
Copy link
Collaborator

m7kvqbe1 commented Sep 21, 2020

Looks like this asset is also missing:

https://github.com/Royal-Navy/design-system/blob/master/packages/icon-library/src/assets/icons/action/settings.svg

This is being consumed by a React Component Library Masthead component story.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 8667 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 8559 lines exceeds the maximum allowed for the inline comments feature.

@codeclimate
Copy link

codeclimate bot commented Sep 23, 2020

Code Climate has analyzed commit 35c0714 and detected 0 issues on this pull request.

View more on Code Climate.

@hxltrhuxze hxltrhuxze merged commit 1aee3f8 into master Sep 23, 2020
@hxltrhuxze hxltrhuxze deleted the feat/newIcons branch September 23, 2020 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: icon-library Package/code type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants