-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(IconLibrary): Add chain and chain-break icons. Closes #1319 and #1188 #1456
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 8589 lines exceeds the maximum allowed for the inline comments feature.
Looks like this is missing as part of this PR: It's causing some component library tests for fail for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 8589 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 8553 lines exceeds the maximum allowed for the inline comments feature.
Codecov Report
@@ Coverage Diff @@
## master #1456 +/- ##
=======================================
Coverage 98.37% 98.37%
=======================================
Files 167 167
Lines 1661 1661
Branches 404 404
=======================================
Hits 1634 1634
Misses 27 27 |
f149fc5
to
88e6e0b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 8553 lines exceeds the maximum allowed for the inline comments feature.
88e6e0b
to
9afa0eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 8553 lines exceeds the maximum allowed for the inline comments feature.
Looks like this asset is also missing: This is being consumed by a React Component Library Masthead component story. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 8667 lines exceeds the maximum allowed for the inline comments feature.
5e1a4d0
to
35c0714
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 8559 lines exceeds the maximum allowed for the inline comments feature.
Code Climate has analyzed commit 35c0714 and detected 0 issues on this pull request. View more on Code Climate. |
Adds new icons
chain
andchain-break
.As I've also reworked how the svg icons work in Sketch, this PR also fixes the incorrectly sized home icon