Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Modal): Resolve incorrect use of ButtonGroup wrapper #2362

Merged
merged 1 commit into from
May 17, 2021
Merged

fix(Modal): Resolve incorrect use of ButtonGroup wrapper #2362

merged 1 commit into from
May 17, 2021

Conversation

m7kvqbe1
Copy link
Collaborator

Related issue

Closes #2268

Overview

Resolve incorrect usage of ButtonGroup wrapper.

Reason

The Modal and Dialog buttons were not styled correctly.

Work carried out

  • Resolve visual discrepencies

Screenshot

Screenshot 2021-05-14 at 11 26 35

@m7kvqbe1 m7kvqbe1 added Type: Bug Inconsistencies or issues which have caused a problem for users or implementors Package: react-component-library Package/code type labels May 14, 2021
@m7kvqbe1 m7kvqbe1 requested review from hxltrhuxze and thyhjwb6 May 14, 2021 10:30
@m7kvqbe1 m7kvqbe1 self-assigned this May 14, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@m7kvqbe1 m7kvqbe1 changed the title fix(Modal): Resolve incorrect use of ButtonGroup wrapper fix(Modal): Resolve incorrect use of ButtonGroup wrapper May 14, 2021
thyhjwb6
thyhjwb6 approved these changes May 17, 2021
View reviewed changes
Copy link
Collaborator

@thyhjwb6 thyhjwb6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@m7kvqbe1 m7kvqbe1 force-pushed the fix/dialog-button-styling branch from 0ca8e5a to aa764fa Compare May 17, 2021 10:09
@m7kvqbe1 m7kvqbe1 merged commit dff5cf0 into master May 17, 2021
@m7kvqbe1 m7kvqbe1 deleted the fix/dialog-button-styling branch May 17, 2021 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thyhjwb6 thyhjwb6 thyhjwb6 approved these changes

@hxltrhuxze hxltrhuxze Awaiting requested review from hxltrhuxze

Assignees

@m7kvqbe1 m7kvqbe1

Labels
Package: react-component-library Package/code type Type: Bug Inconsistencies or issues which have caused a problem for users or implementors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dialog button styling broken
2 participants
@m7kvqbe1 @thyhjwb6