Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Tooltip): Add missing border unit #3237

Merged
merged 1 commit into from
Apr 13, 2022
Merged

fix(Tooltip): Add missing border unit #3237

merged 1 commit into from
Apr 13, 2022

Conversation

m7kvqbe1
Copy link
Collaborator

Related issue

Closes #3236

Overview

Add missing unit to CSS border property.

@m7kvqbe1 m7kvqbe1 added Type: Bug Inconsistencies or issues which have caused a problem for users or implementors Package: react-component-library Package/code type Type: Development Related to a design system component labels Apr 13, 2022
@m7kvqbe1 m7kvqbe1 requested a review from thyhjwb6 as a code owner April 13, 2022 10:35
@m7kvqbe1 m7kvqbe1 self-assigned this Apr 13, 2022
@m7kvqbe1 m7kvqbe1 requested a review from jpveooys as a code owner April 13, 2022 10:35
jpveooys
jpveooys approved these changes Apr 13, 2022
View reviewed changes
Copy link
Collaborator

@jpveooys jpveooys left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good – isn't this Tooltip though 😄

@m7kvqbe1 m7kvqbe1 changed the title fix(Popover): Add missing border unit fix(Tooltip): Add missing border unit Apr 13, 2022
@m7kvqbe1 m7kvqbe1 force-pushed the fix/popover-style-typo branch from e3aefb9 to 8507d7f Compare April 13, 2022 11:23
@m7kvqbe1 m7kvqbe1 merged commit e23dd40 into master Apr 13, 2022
@m7kvqbe1 m7kvqbe1 deleted the fix/popover-style-typo branch April 13, 2022 11:24
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpveooys jpveooys jpveooys approved these changes

@thyhjwb6 thyhjwb6 Awaiting requested review from thyhjwb6

Assignees

@m7kvqbe1 m7kvqbe1

Labels
Package: react-component-library Package/code type Type: Bug Inconsistencies or issues which have caused a problem for users or implementors Type: Development Related to a design system component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid css in Tooltip(missing measurement unit)
2 participants
@m7kvqbe1 @jpveooys