Introduce INF/NAN string values normalizer #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
| /** | ||
| * @var array<string, float> | ||
| */ | ||
| private array $replacements = [ |
There was a problem hiding this comment.
I believe this could be a constant
| @@ -0,0 +1,59 @@ | |||
| <?php | |||
There was a problem hiding this comment.
Is 'Normalize' really what this class is doing? I think the naming could work in other domains but since we're in the context of machine learning maybe we choose a different word. Normalize has a specific meaning in ML.
On the contrary, maybe InfNan is too specific. We might need to convert others in the future in which case the naming would not be valid. Naming is hard.
Would ConvertRequestBodyConstants work?
| @@ -0,0 +1,99 @@ | |||
| <?php | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.