Update deprecation message to suggest correct formatting. #1056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current deprecation message for the before or after symbol suggests using a format string that includes spaces. This is a small change so that the deprecation warning is more useful. Co-authored-by: Alec Clarke <alec.clarke.dev@gmail.com>
nicholalexander
commented
Jun 9, 2023
|
|
||
| context 'when the position is :before' do | ||
| it 'warns about deprecated :symbol_position' do | ||
| expect_any_instance_of(Money::FormattingRules).to receive(:warn) |
There was a problem hiding this comment.
Note: We're aware that using any_instance_of may not be great - but given that the deprecation code is called on initialize and the spec helper warning modules are noops, it is difficult to assert against the deprecation warning strings.
We are up for alternatives on testing!
semmons99
approved these changes
Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current deprecation message for the before or after symbol suggests using a format string that includes spaces. This is a small change so that the deprecation warning is more useful.
Co-authored-by: Alec Clarke alec.clarke.dev@gmail.com