-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove localize formatting rules #650
Remove localize formatting rules #650
Conversation
@yukihariguchi thanks for the PR, looks legit from what I can tell. Do you have any examples of this? Wiki or any other resource? Also, |
@yukihariguchi any chance you can rebase this PR and answer my question? Thanks! |
@pwim do you have any suggestions here? |
I've taken a look at some of the top ecommerce sites in Japan. So as of 2018, it seems that using ¥ rather than 円 is more common. Maybe the situation was different back in 2011 when I first made #101, or maybe I was misguided and it wasn't necessary. Given this, I'm fine for my application displaying "¥500" instead of "500円", and so I'm not opposed to this PR. This is a breaking change, so it should probably go into the next major version. |
Additionally, I'd call out that this changes how Japanese yen is formatted explicitly in the changelog. Something like
|
@pwim since I'm not familiar with the matter I trust your judgment. Thank you for pointing out that it's a breaking change and sketching a text for changelog, really appreciate that! @yukihariguchi can you please rebase the PR? |
Since
Formatting#localize_formatting_rules
prevent from overwriting rules, this patch is going to propose to removeFormatting#localize_formatting_rules
.First of all, this method was introduced at #101. But it doesn't make sense to me and unexpected behavior. Not only '円' but also '圓'(it's more formal) or even 'yen' can be used.