SwiftMetrics fails to build with Swift 3.1 #89

tobespc · 2017-03-27T13:01:54Z

No description provided.

tobespc · 2017-03-29T18:20:42Z

logs similar to this are the issue

Fetching https://github.com/IBM-Swift/Kitura-Request.git
Fetching https://github.com/IBM-Swift/CloudConfiguration.git
error: fatal error: Error raised at top level: Error Domain=NSCocoaErrorDomain Code=4 ""org.eclipse.paho.mqtt.c" couldn't be moved to "src" because either the former doesn't exist, or the folder containing the latter doesn't exist." UserInfo={NSSourceFilePathErrorKey=/Users/kweinmeister/Documents/Xcode/tmpProj/org.eclipse.paho.mqtt.c, NSUserStringVariant=(
    Move
), NSDestinationFilePath=/Users/kweinmeister/Documents/Xcode/tmpProj/src/paho, NSFilePath=/Users/kweinmeister/Documents/Xcode/tmpProj/org.eclipse.paho.mqtt.c, NSUnderlyingError=0x7fb738efa180 {Error Domain=NSPOSIXErrorDomain Code=2 "No such file or directory"}}: file /Library/Caches/com.apple.xbs/Sources/swiftlang/swiftlang-802.0.48/src/swift/stdlib/public/core/ErrorType.swift, line 188
Current stack trace:
0    libswiftCore.dylib                 0x000000010903a160 swift_reportError + 129
1    libswiftCore.dylib                 0x0000000109056a70 _swift_stdlib_reportFatalErrorInFile + 100

tobespc · 2017-03-30T08:45:24Z

We are looking to embed the omr-agentcore code into SwifMetrics in the short term to resolve the build issues with 3.1

lroseblade · 2017-03-30T08:50:07Z

@tobespc as in a fork of omr-agentcore until the custom module layouts are supported in SPM?

tobespc · 2017-03-30T09:00:39Z

we are not going to fork, going to have the code as part of swiftmetrics for now Regards, Toby Corbin Monitoring Architect/Lead Developer, Consumability Tooling IBM Runtime Technologies Phone: +44-1962-816995 | Tie-Line: 37246995 E-mail: corbint@uk.ibm.com Follow IBM Java on: IBM Monitoring and Diagnostic Tools Website IBM Java Diagnostic Guides IBM UK Ltd, Hursley Park Hursley , SO212JN United Kingdom From: Lloyd Roseblade <notifications@github.com> To: RuntimeTools/SwiftMetrics <SwiftMetrics@noreply.github.com> Cc: Toby Corbin/UK/IBM@IBMGB, Mention <mention@noreply.github.com> Date: 30/03/2017 09:50 Subject: Re: [RuntimeTools/SwiftMetrics] SwiftMetrics fails to build with Swift 3.1 (#89) @tobespc as in a fork of omr-agentcore until the custom module layouts are supported in SPM? ? You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread. Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU

sjanuary · 2017-04-03T13:04:26Z

SwiftMetrics now works on 3.1 if you use the branch swift-3.1. SwiftMetricsDash is not working yet, currently hitting Kitura/Kitura-WebSocket#5

cdlliuy · 2017-04-07T01:12:05Z

@sjanuary @tobespc , Swift 3.1 is uploaded to Dallas YP now, then push swift application to YP with "swiftmetric", the master branch is always used, so the staging failure is observed.

Could you merge the fix into master branch to fix the build break as early as possible ?

tobespc · 2017-04-07T07:14:16Z

we will do but until the Kitura/Kitura-WebSocket#5 is fixed the dashboard is not going to work. This means you won't be able to use the SwiftMetrics Dashboard

cdlliuy · 2017-04-07T09:32:56Z

I concern more for the staging failure currently for bluemix apps. It is build broken for related users.

cdlliuy · 2017-04-11T01:09:41Z

@sjanuary @tobespc , stills failing when push swift metrics apps to bluemix. It is a build broken, and it is not fixed for about 15 days ..

tobespc · 2017-04-11T06:59:29Z

We cant merge into master yet as once we do, due to new dependencies required to work for Swift 3.1, Swift 3.0 will be broken. Can the build pack be changed to pull from a difference branch in the short term?

cdlliuy · 2017-04-11T07:29:05Z

I don't know how it would be configure through buildpack. I asked in slack @swift channel to find the contact point of swift build pack team

tobespc · 2017-04-11T08:20:55Z

We are going to fix the build issue today so that the buildpack will work. The dashboard won't be working until we get an apple bug fixed but at least the build will work

sjanuary · 2017-04-11T09:10:19Z

@cdlliuy - FYI the bug in Swift core that is blocking us is https://bugs.swift.org/browse/SR-4435.
I think Swift 3.0 can still be used on Bluemix even though 3.1 is the default?

cdlliuy · 2017-04-11T09:33:55Z

@sjanuary， it looks like the swift 3.1 is selected by default now. I am expert for swift buildpack, you can check with buildpack team. anyway, I didn't get a name to contact swift buildpack team yet, please help to figure out.

mattcolegate · 2017-04-11T09:52:12Z

I think the Swift Buildpack is hosted at https://github.com/IBM-Swift/swift-buildpack. Given the activity in there, @rolivieri seems like someone to contact to start with.

tunniclm · 2017-04-11T10:03:22Z

IIRC you can configure the version of Swift used by the build pack via the .swift-version file:https://github.com/IBM-Swift/swift-buildpack#specify-a-swift-version

lroseblade · 2017-04-11T10:10:50Z

I will speak with the relevant parties today and post back in here. @rolivieri is no longer owner of the buildpack.

lroseblade · 2017-04-11T14:54:55Z

This will be discussed at the Swift TSC on Thursday

cdlliuy · 2017-04-12T01:14:36Z

@tunniclm , I am not sure whether the workaround of .swift-version is well known workaround by end-user .. What is the release process of swift buildpack? I worked with liberty and node.js buildpack team previously, they will send out release announcement and call for related/dependency team's comments when released on YS1. If no failure detected, will continue to publish to YP. I am not sure whether swift buildpack is following the similar process. The build failure should be detected and reported to Swift buildpack team before the version 3.1 goes to production.

cdlliuy · 2017-04-12T01:18:25Z

Is there any build failure monitoring in Swift metrics team? It means compile swift metrics apps, push to bluemix everyday (or more frequently, i.e every 2 hours) to detect any possible failures. The continuous build/test/delivery process will help to detect failure promptly.

rolivieri · 2017-04-12T02:20:29Z

All, I just saw this thread.

Our recommendation is that all Swift apps should contain a .swift-version file with the corresponding Swift version. That should take care of any issues that may be occurring with having 3.1 as the default version in the builpack. If an app should be provisioned on Bluemix using 3.0.2 (or a different version), then having this file will ensure the buildpack uses the corresponding Swift version. Using a .swift-version file has become a best practice in the Swift development world. The buildpack is simply leveraging something that has become a de facto standard for Swift developers (other tools also leverage this file such as swiftenv).

Having SwiftMetrics compiled with the latest version of Swift has not been a requirement for updating the buildpack. They are separate and independent artifacts. One of the main goals that we as a team have been aiming at is the adoption of new Swift versions as soon as they come out. Among the main artifacts that are affected by this goal are the buildpack, our docker images, and package-builder.

cdlliuy · 2017-04-12T03:22:09Z

@rolivieri , got it. I found .swift_version related documents in swift buildpack, so that we (auto-scaling) team can add related trouble shooting link as well , so that if end-user has staging error of swiftmetric, they are check SwiftBuildpack documentation to get a solution as well.

@tobespc , I suggest to add a section of "support swift version" in readme.md, so that the user can check the latest supported swift version easily when checking the git project.

On the other hand, although the end-user can downgrade to v3.0.2 with .swift_version, I still suggest to add continuous test to detect whether swift metric & latest swift engine are compatible, and fix the incompatible issue as early as possible.

sjanuary · 2017-04-12T15:07:36Z

Update: SwiftMetrics @1.0.2 now builds on 3.1 although the dashboard (SwiftMetricsDash) will not work due to the issue referenced above.

cdlliuy · 2017-04-13T08:51:32Z

@sjanuary @tobespc , the fix did work to fix the "staging" error, BUT the swift apps keep crashing when running on bluemix.

here is "cf logs --recent " record:

2017-04-13T16:41:14.31+0800 [CELL/0] 2017-04-13T16:41:15.05+0800 [CELL/0] 2017-04-13T16:41:20.67+0800 [CELL/0] 2017-04-13T16:41:21.06+0800 [APP/0] 2017-04-13T16:41:21.06+0800 [APP/0] 2017-04-13T16:41:22.76+0800 [CELL/0] 2017-04-13T16:43:19.27+0800 [APP/0] 2017-04-13T16:43:19.27+0800 [APP/0] 2017-04-13T16:43:25.27+0800 [APP/0] 2017-04-13T16:43:25.27+0800 [APP/0] 2017-04-13T16:43:25.29+0800 [CELL/0] 2017-04-13T16:43:25.30+0800 [CELL/0] 2017-04-13T16:43:25.31+0800 [API/2] 2017-04-13T16:43:25.92+0800 [CELL/0] 2017-04-13T16:45:44.85+0800 [CELL/0] 2017-04-13T16:45:49.19+0800 [CELL/0] 2017-04-13T16:45:53.33+0800 [CELL/0] 2017-04-13T16:45:53.50+0800 [APP/0] 2017-04-13T16:45:53.50+0800 [APP/0] 2017-04-13T16:45:54.56+0800 [APP/0] 2017-04-13T16:45:54.56+0800 [APP/0] 2017-04-13T16:45:55.44+0800 [CELL/0] 2017-04-13T16:47:21.60+0800 [APP/0] 2017-04-13T16:47:21.63+0800 [CELL/0] 2017-04-13T16:47:21.63+0800 [CELL/0] 2017-04-13T16:47:21.64+0800 [API/1] OUT Creating container
OUT Successfully created container
OUT Starting health monitoring of container
ERR [Thu Apr 13 08:41:21 2017] com.ibm.diagnostics.healthcenter.loader INFO: Swift Application Metrics
OUT SwiftMetrics: Error finding install directory
OUT Container became healthy
ERR [Thu Apr 13 08:43:19 2017] com.ibm.diagnostics.healthcenter.plugins WARNING: [cpu_os] At least one data gathering failure occurred
OUT results: [Optional(CloudFoundryEnv.Service)]
ERR *** Error in `Your-App': double free or corruption (fasttop): 0x00007f72200008e0 ***
OUT Exit status 134
OUT Exit status 0
OUT Destroying container
OUT App instance exited with guid 147f37dd-ebe9-418a-b756-5331b4e9f205 payload: {"instance"=>"", "index"=>0, "reason"=>"CRASHED", "exit_description"=>"2 error(s) occurred:\n\n* 2 error(s) occurred:\n\n* Exited with status 134\n* cancelled\n* cancelled", "crash_count"=>5, "crash_timestamp"=>1492073005301698935, "version"=>"d99f3e4f-f92d-41e6-a2ac-79eab3f8feb0"}
OUT Successfully destroyed container
OUT Creating container
OUT Successfully created container
OUT Starting health monitoring of container
OUT SwiftMetrics: Error finding install directory
ERR [Thu Apr 13 08:45:53 2017] com.ibm.diagnostics.healthcenter.loader INFO: Swift Application Metrics
OUT results: [Optional(CloudFoundryEnv.Service)]
ERR [Thu Apr 13 08:45:54 2017] com.ibm.diagnostics.healthcenter.plugins WARNING: [cpu_os] At least one data gathering failure occurred
OUT Container became healthy
OUT Exit status 139
OUT Exit status 0
OUT Destroying container
OUT App instance exited with guid 147f37dd-ebe9-418a-b756-5331b4e9f205 payload: {"instance"=>"", "index"=>0, "reason"=>"CRASHED", "exit_description"=>"2 error(s) occurred:\n\n* 2 error(s) occurred:\n\n* Exited with status 139\n* cancelled\n* cancelled", "crash_count"=>6, "crash_timestamp"=>1492073241637097043, "version"=>"d99f3e4f-f92d-41e6-a2ac-79eab3f8feb0"}

I tried to add .swift-version file with "3.0.2" , then the same application ran correctly. Then change back to 3.1, failed again..

So, I think the fix didn't work as we expected.

ianpartridge · 2017-04-13T13:38:17Z

Swift 3.1 contains a memory corruption bug and should be considered broken. The memory corruption is known to be triggered by accessing the SwiftMetrics dashboard, but could occur at any time.

It is likely that Swift 3.1.1 will be released soon with a fix for the issue. Until then, please use Swift 3.0.2

qibobo · 2017-04-14T00:30:46Z

@ianpartridge is there a target date when the v3.1.1 will be released?

ianpartridge · 2017-04-14T10:09:03Z

No, this is Apple's decision. Hopefully it will be soon.

mattcolegate · 2017-04-25T14:09:50Z

3.1.1 is now released. @cdlliuy can you please test again with 3.1.1 and check if the problem still occurs?

tobespc · 2017-04-25T14:45:05Z

fyi CPU and Environment is not working currently

cdlliuy · 2017-04-26T02:27:22Z

The 3.1.1 version is not released on Bluemix YS1/LYS1.
swift_buildpack 4 true false buildpack_swift_v2.0.5-20170406-2317.zip

So, I will wait until the next swift buildpack released on staging . @rolivieri

rolivieri · 2017-04-26T19:19:15Z

@cdlliuy You don't need to wait for the next version of the buildpack to test. Just make sure you have a .swift-version file in your test application. The buildpack will download the version of Swift that you request in the .swift-version file.

cdlliuy · 2017-04-27T02:43:42Z

@rolivieri, my test app is included .swift_version with 3.0.2 now, so it is good. But @mattcolegate is asking me to try on 3.1.1 now, so I would like to wait for the next buildpack

tobespc · 2017-04-27T08:07:00Z

@cdlliuy we have an issue with SwiftMetrics on Swift 3.1.1 right now with it crashing. Should have a fix in for that later today

mattcolegate · 2017-04-27T08:51:22Z

@tobespc I think this issue has crept beyond it's original purpose. SwiftMetrics now builds on 3.1. Unfortunately it crashes at runtime, but shouldn't that be a separate issue? I believe this issue should be closed.

tobespc · 2017-04-27T09:46:15Z

closing as tracked under #104

rolivieri · 2017-04-27T14:15:37Z

@cdlliuy My point was more around the following lines: To test SwiftMetrics (when Toby and Matt have a version ready for you for testing) on Bluemix, you can update your .swift-version file to have 3.1.1 instead of 3.0.2 (i.e. testing on Bluemix using 3.1.1 can be done today even though the new version of the buildpack is not there yet).

tobespc added the bug label Mar 27, 2017

mattcolegate added this to the 1.2 milestone Apr 25, 2017

tobespc added investigate and removed bug labels Apr 25, 2017

tobespc closed this as completed Apr 27, 2017

SwiftMetrics fails to build with Swift 3.1 #89

SwiftMetrics fails to build with Swift 3.1 #89

Comments

tobespc commented Mar 27, 2017

tobespc commented Mar 29, 2017

tobespc commented Mar 30, 2017

lroseblade commented Mar 30, 2017

tobespc commented Mar 30, 2017 via email

sjanuary commented Apr 3, 2017 • edited Loading

cdlliuy commented Apr 7, 2017

tobespc commented Apr 7, 2017

cdlliuy commented Apr 7, 2017

cdlliuy commented Apr 11, 2017

tobespc commented Apr 11, 2017

cdlliuy commented Apr 11, 2017

tobespc commented Apr 11, 2017

sjanuary commented Apr 11, 2017

cdlliuy commented Apr 11, 2017

mattcolegate commented Apr 11, 2017

tunniclm commented Apr 11, 2017

lroseblade commented Apr 11, 2017

lroseblade commented Apr 11, 2017

cdlliuy commented Apr 12, 2017

cdlliuy commented Apr 12, 2017

rolivieri commented Apr 12, 2017 • edited Loading

cdlliuy commented Apr 12, 2017

sjanuary commented Apr 12, 2017

cdlliuy commented Apr 13, 2017

ianpartridge commented Apr 13, 2017

qibobo commented Apr 14, 2017

ianpartridge commented Apr 14, 2017

mattcolegate commented Apr 25, 2017

tobespc commented Apr 25, 2017

cdlliuy commented Apr 26, 2017

rolivieri commented Apr 26, 2017 • edited Loading

cdlliuy commented Apr 27, 2017

tobespc commented Apr 27, 2017

mattcolegate commented Apr 27, 2017 • edited Loading

tobespc commented Apr 27, 2017

rolivieri commented Apr 27, 2017

sjanuary commented Apr 3, 2017 •

edited

Loading

rolivieri commented Apr 12, 2017 •

edited

Loading

rolivieri commented Apr 26, 2017 •

edited

Loading

mattcolegate commented Apr 27, 2017 •

edited

Loading