Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Swift 3.1 (SwiftMetricsDash not currently working) #96

Merged
merged 22 commits into from
Apr 12, 2017

Conversation

sjanuary
Copy link
Contributor

Needed to pull in agentcore code to be able to build on Swift 3.1 as code can no longer be executed in Package.swift. We also have a new Package@swift-3.1.swift to enable different levels of the dependencies for 3.1 and some code changes required because the install directory has changed from Packages to .build/checkouts between 3.0 and 3.1. SwiftMetricsDash does not currently work on Swift 3.1 due to a WebSockets issue (Kitura/Kitura-WebSocket#5).

@sjanuary sjanuary requested a review from mattcolegate April 12, 2017 09:34
@codecov-io
Copy link

codecov-io commented Apr 12, 2017

Codecov Report

Merging #96 into master will increase coverage by 0.52%.
The diff coverage is 1.55%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #96      +/-   ##
=========================================
+ Coverage       0%   0.52%   +0.52%     
=========================================
  Files           5      82      +77     
  Lines         818    8207    +7389     
=========================================
+ Hits            0      43      +43     
- Misses        818    8164    +7346
Flag Coverage Δ
#SwiftMetrics 0% <0%> (ø) ⬆️
#SwiftMetricsBluemix 0% <0%> (ø) ⬆️
#SwiftMetricsDash 0% <0%> (ø) ⬆️
#SwiftMetricsKitura 0% <0%> (ø) ⬆️
#agentcore 1.51% <2.12%> (?)
#cpuplugin 1.43% <1.95%> (?)
#envplugin 1.35% <1.81%> (?)
#hcapiplugin 1.32% <1.76%> (?)
#memplugin 1.27% <1.66%> (?)
#mqttplugin 1.2% <1.55%> (?)
#ostreamplugin 1.2% <1.55%> (?)
#paho 0.52% <1.55%> (?)
Impacted Files Coverage Δ
Sources/paho/include/MQTTAsync.h 0% <ø> (ø)
Sources/paho/src/MQTTPersistence.c 0% <ø> (ø)
Sources/paho/include/MQTTPersistence.h 0% <ø> (ø)
Sources/paho/src/Clients.c 0% <ø> (ø)
Sources/paho/src/MQTTProtocolClient.c 0% <ø> (ø)
Sources/paho/src/utf-8.c 0% <ø> (ø)
Sources/paho/src/Tree.c 0% <ø> (ø)
Sources/paho/include/Thread.h 0% <ø> (ø)
Sources/paho/src/Heap.c 0% <ø> (ø)
Sources/paho/include/SocketBuffer.h 0% <ø> (ø)
... and 146 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d01ffd0...df8c67d. Read the comment docs.

Copy link
Member

@mattcolegate mattcolegate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me

@mattcolegate mattcolegate merged commit 299065a into master Apr 12, 2017
@mattcolegate mattcolegate deleted the swift-3.1 branch August 2, 2017 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants