-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Swift 3.1 (SwiftMetricsDash not currently working) #96
Conversation
Support Swift 3.1
* install directory has changed * remove whitespace changes
Separate package.swift for Swift 3.1
Codecov Report
@@ Coverage Diff @@
## master #96 +/- ##
=========================================
+ Coverage 0% 0.52% +0.52%
=========================================
Files 5 82 +77
Lines 818 8207 +7389
=========================================
+ Hits 0 43 +43
- Misses 818 8164 +7346
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good to me
Needed to pull in agentcore code to be able to build on Swift 3.1 as code can no longer be executed in Package.swift. We also have a new Package@swift-3.1.swift to enable different levels of the dependencies for 3.1 and some code changes required because the install directory has changed from
Packages
to.build/checkouts
between 3.0 and 3.1. SwiftMetricsDash does not currently work on Swift 3.1 due to a WebSockets issue (Kitura/Kitura-WebSocket#5).