Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CanonicalPath for impl #2633

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Fix CanonicalPath for impl #2633

merged 1 commit into from
Sep 26, 2023

Conversation

tamaroning
Copy link
Contributor

@tamaroning tamaroning commented Sep 20, 2023 •
edited
Loading

Fix #2631

gcc/rust/ChangeLog:

	* util/rust-canonical-path.h: Add new segment kind for inherent impl.
	* resolve/rust-ast-resolve-item.cc (ResolveItem::visit): Use it.
	* resolve/rust-ast-resolve-toplevel.h: Use it.

@tamaroning tamaroning force-pushed the fix-impl-path branch 4 times, most recently from a5e4652 to c09b8a0 Compare September 21, 2023 10:11
@tamaroning tamaroning marked this pull request as ready for review September 21, 2023 10:13
@tamaroning
Copy link
Contributor Author

I noticed problems remain. please do not review now.

@tamaroning
Fix CanonicalPath for inherent impl
0f3df91 
gcc/rust/ChangeLog:

	* util/rust-canonical-path.h: Add new segment kind for inherent impl.
	* resolve/rust-ast-resolve-item.cc (ResolveItem::visit): Use it.
	* resolve/rust-ast-resolve-toplevel.h: Use it.

Signed-off-by: Raiki Tamura <tamaron1203@gmail.com>
@tamaroning tamaroning mentioned this pull request Sep 21, 2023
Merged
@tamaroning
Copy link
Contributor Author

tamaroning commented Sep 22, 2023 •
edited
Loading

Fixed.

@P-E-P P-E-P mentioned this pull request Sep 25, 2023
Merged
P-E-P
P-E-P approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@P-E-P P-E-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@P-E-P P-E-P added this to the GCC 14 Stage 3 milestone Sep 26, 2023
@P-E-P P-E-P added this pull request to the merge queue Sep 26, 2023
Merged via the queue into Rust-GCC:master with commit d0742b3 Sep 26, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-E-P P-E-P P-E-P approved these changes

@CohenArthur CohenArthur Awaiting requested review from CohenArthur

Assignees
No one assigned
Labels
enhancement
Projects
libcore 1.49
Status: Done
Milestone
GCC 14 Stage 3
Development

Successfully merging this pull request may close these issues.

Improper CanonicalPath for impl
2 participants
@tamaroning @P-E-P