cargo update & lint/clippy/rustfmt/cargo-deny fixes.
#3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, just noticed "Ensure compatibility with rust-gpu nightly rust version" check doesn't actually do anything because of how the |
eddyb
force-pushed
the
ci-fix
branch
3 times, most recently
from
bdf3dcf
to
e018d86
Compare
|
"Ensure compatibility with rust-gpu nightly rust version" check works now, it even fully builds with only this warning: (if we were running |
eddyb
changed the title
cargo update & lint/clippy/rustfmt fixes.cargo update & lint/clippy/rustfmt/cargo-deny fixes.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
The merge queue failure was real, literally today's nightly introduced it: Will open another PR. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 4, 2024
*(This won't pass CI until #3 lands)* Similar to EmbarkStudios/spirt#61, the main reason for the bump is to avoid being stuck behind on definitions in a new release (even when there's not much going on).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the remaining CI failures.
The
rustfmt.tomlchange was prompted by @Firestar99's formatting changes in #2, and the subsequent local rebasing, withversion = "Two"causing warnings due to:So the perma-unstable
rustfmt.tomlversionconfig is nowstyle_edition = "2024", and hopefully that gets stabilized at the same time as Rust 2024 becoming stable.