Rename ControlRegion to just Region.
#7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 6, 2024
…`). (#12) Effectively undoes: - EmbarkStudios/spirt#28 Some quick unscientific testing reveals no significant perf impact (i.e. the difference is lost in the noise). The motivation for undoing this interning is the prospect of combining `DataInstDef` into `NodeDef` (as mentioned in #7), and for unrelated pragmatic reasons, `NodeDef` can't have its outputs interned (though long-term maybe we could intern the `kind` field, if really necessary, assuming we first take "child regions" out of it). The one thing I realized too late there's no pre-existing consensus for, is the `output_type`, which used to be between `kind` and `inputs` (matching `DataInstFormDef`, in fact), while `NodeDef`'s `outputs` is the last field. The only argument to have outputs first is the `let (out0, out1) = foo(in0, in1);` style syntax (though pretty-printed SPIR-T omits the `let`), but I'm not sure that's worth flipping the order over.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by some ideas around fusing
ControlNode+DataInst(as justNode/Op/etc.), and unlike those two there is really no reason to distinguish between "kinds of regions".Also used this as a test of a new
jjfeature which allowed me to rebase 50 commits downstream of this painlessly (by preventing the normal propagation of diffs, so each commit could be independently rewritten, and those that haven't been yet would have the opposite rename in their diff):(the new feature being
--restore-descendants, which could better be described as "firewall descendants (downstream/future commits) from these changes")&& jj nextat the end only really handles the "main chain" of changes, so after that was done, replacing it with this, at the start, made it possible to chew through the remaining side commits: