Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add load_texture_bytes interface for load texture from buffer #1014

Merged
merged 2 commits into from
Jul 14, 2020
Merged

add load_texture_bytes interface for load texture from buffer #1014

merged 2 commits into from
Jul 14, 2020

Conversation

netcan
Copy link
Contributor

@netcan netcan commented Jun 27, 2020

@netcan
Copy link
Contributor Author

netcan commented Jul 13, 2020

@Cobrand

@Cobrand
Copy link
Member

Cobrand commented Jul 13, 2020

Sorry, somehow I missed this. Rename the method to load_texture_bytes or load_texture_image_bytes and add a comment that the format must be something supported by SDL2_image (png, jpeg, ect, but NOT RGBA8888 bytes for instance).

@netcan
Copy link
Contributor Author

netcan commented Jul 14, 2020

I have fixed it. @Cobrand

@netcan netcan changed the title add load_texture_rw interface for load texture from buffer add load_texture_bytes interface for load texture from buffer Jul 14, 2020
@Cobrand
Copy link
Member

Cobrand commented Jul 14, 2020

Thanks!

@Cobrand Cobrand merged commit 36a1f61 into Rust-SDL2:master Jul 14, 2020
sypwex pushed a commit to sypwex/rust-sdl2 that referenced this pull request Jun 2, 2024
@Cobrand
Merge pull request Rust-SDL2#1014 from netcan/master
e8bd6a1 
add load_texture_bytes interface for load texture from buffer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@netcan @Cobrand