Add SDL2 patch to fix metal detection for macOS/iOS #1030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just to add clarity.. an upstream error in SDL2 2.0.12 is causing sdl2-sys 0.34.3 to have metal/vulkan disabled on macOS/iOS when using the "bundled" feature. This breaks downstream apps using this crate on macOS. Merging this and releasing as 0.34.4 should fix those downstream issues. |
|
Thanks for the hard work! |
Merged
sypwex
pushed a commit
to sypwex/rust-sdl2
that referenced
this pull request
Jun 2, 2024
Add SDL2 patch to fix metal detection for macOS/iOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1028 by patching in a change that is upstreamed but not in 2.0.12
https://hg.libsdl.org/SDL/rev/e7828d3a7576