Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added binding for SDL_GetDisplayUsableBounds. #1100

Merged
merged 2 commits into from
Apr 24, 2021

Conversation

Flaise
Copy link
Contributor

@Flaise Flaise commented Apr 22, 2021

Linux and MacOS will make sure your window fits in the available space but Windows instead makes a window go under the taskbar. Use SDL_GetDisplayUsableBounds to avoid this.

@Cobrand
Copy link
Member

Cobrand commented Apr 23, 2021

This looks good! The fmt check fails though, can you run cargo fmt, commit then push the changes please?

@Flaise
Copy link
Contributor Author

Flaise commented Apr 24, 2021

This looks good! The fmt check fails though, can you run cargo fmt, commit then push the changes please?

There, is that better?

@Cobrand
Copy link
Member

Cobrand commented Apr 24, 2021

Thanks!

@Cobrand Cobrand merged commit 3374653 into Rust-SDL2:master Apr 24, 2021
@Flaise
Copy link
Contributor Author

Flaise commented Apr 27, 2021

Excellent. Any idea when these changes will be made to show up on crates.io?

@Cobrand
Copy link
Member

Cobrand commented Apr 27, 2021

I just published 0.34.5 which includes this PR.

sypwex pushed a commit to sypwex/rust-sdl2 that referenced this pull request Jun 2, 2024
Added binding for SDL_GetDisplayUsableBounds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants