Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update raw-window-handle to 0.4 #1182

Merged
merged 1 commit into from
Dec 19, 2021
Merged

Update raw-window-handle to 0.4 #1182

merged 1 commit into from
Dec 19, 2021

Conversation

17cupsofcoffee
Copy link
Contributor

@17cupsofcoffee 17cupsofcoffee commented Dec 19, 2021

This is required for Rust-SDL2 to work with the latest version of WGPU.

This would usually be a breaking change, but thankfully raw-window-handle have used the semver trick to do a compatibility release of 0.3. This means that any 0.4 HasRawWindowHandle also implements the 0.3 HasRawWindowHandle (hence why the WGPU example hasn't broken as a result of this change).

I did try to update the WGPU example too, but I don't know the API well enough to do so.

I have tested this on Windows and it seems to work - I don't have any way of testing other OSes, but the API changes seem fairly uniform, so hopefully it should all be fine? Will wait and see how the CI build goes :)

Summary of changes:

  • Loads of stuff got renamed.
  • All of the structs are non-exhaustive now, so we can't use the .. syntax to build them.

@Cobrand
Copy link
Member

Cobrand commented Dec 19, 2021

Thanks!

@toyboot4e
Copy link

toyboot4e commented Jan 8, 2022

Could you run cargo publish?

This is PR is nice and resolves my build issue, but it looks like the latest rust-sdl2 is not available yet.

I can use the master directly though. Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants