Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update raw-window-handle to 0.5.0 #1275

Merged
merged 3 commits into from
Dec 23, 2022

Conversation

Nuckal777
Copy link
Contributor

@Nuckal777 Nuckal777 commented Dec 16, 2022

Resolves #1269

I tested this on:

  • Linux with X11: raw-window-handle test pass and the example shows the triangle.
  • Windows with Win32: raw-window-handle test pass and the example shows the triangle.
  • MacOS: The example works and shows the triangle. We need SDL to construct a SDL_MetalView though, which likely means one can only use Metal afterwards. The test fails to run with the same error as in AppKit Error when using VideoSubsystem on MacOS after installing #1151. The mentioned issue is caused by cargo test using multiple threads.

Other platforms are best effort guess work.

@Nuckal777 Nuckal777 force-pushed the update-raw-window-handle branch from fb65495 to 2db28e0 Compare December 18, 2022 21:53
@Cobrand
Copy link
Member

Cobrand commented Dec 20, 2022

The mentioned issue is caused by cargo test using multiple threads.

You can confirm this is the issue by setting the env variable RUST_TEST_THREADS to 1 (which is already set on CI).

Could you please check to confirm this does fix it? Other than that, it looks good. Thanks!

@Nuckal777
Copy link
Contributor Author

RUST_TEST_THREADS=1 makes everything run smoothly. 👍

@Cobrand
Copy link
Member

Cobrand commented Dec 23, 2022

Thanks!

@Cobrand Cobrand merged commit b7d75c5 into Rust-SDL2:master Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support raw-window-handle 0.5
2 participants