Error checking fix for ClipboardUtil::set_clipboard_text
#737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDL_SetClipboardText returns 0 on success, not failure. Before this
fix, calling set_clipboard_text successfully would generally return
Err("").
|
sigh this has not been noticed since this commit, which was 2 years ago. And even then it had the wrong version. Thanks for the PR kyren, appreciate it. I'll update the changelog for you. Tell me if you want this change to be propagated to crates.io soon. |
Cobrand
added a commit
that referenced
this pull request
Dec 12, 2017
|
Thank you for the quick merge! It's not a super big deal for us at least that there be a crates.io release soon, it's very easy to workaround by just ignoring the returned error. If you think it warrants a 0.31.1 release, it would be convenient, but don't go out of your way if it's hugely annoying. |
|
If there are no other PRs during the next week I'll definitely do this. In the meantime, you can use this in your Cargo.toml: [dependencies.sdl2]
git = "https://github.com/rust-sdl2/rust-sdl2"
rev = "35b4931f98f8541e9c67cbd19e800de85315b796" # Dec 11st, 2017 master revisionCheers. |
sypwex
pushed a commit
to sypwex/rust-sdl2
that referenced
this pull request
Jun 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDL_SetClipboardText returns 0 on success, not failure. Before this
fix, calling set_clipboard_text successfully would generally return
Err("").