Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hash impls for Point and Rect #764

Merged
merged 1 commit into from
Mar 31, 2018
Merged

Conversation

mdsteele
Copy link
Contributor

Looks like commit b00e889 removed the existing Hash impls for Rect and Point (by accident, I assume), which broke some of my code that was using HashMap<Point, T> in many places. This PR adds Hash impls back for Rect and Point.

@mdsteele
Copy link
Contributor Author

Hmm, odd. One out of the six travis-ci builds (osx stable) failed, but the failure doesn't seem related to this change:

---- test_events stdout ----
	thread 'test_events' panicked at 'assertion failed: `(left == right)`
  left: `User { timestamp: 0, window_id: 0, type_: 32770, code: 456, data1: 0x1234, data2: 0x5678 }`,
 right: `User { timestamp: 3, window_id: 0, type_: 32770, code: 456, data1: 0x1234, data2: 0x5678 }`', tests/events.rs:41:5
note: Run with `RUST_BACKTRACE=1` for a backtrace.

@Cobrand
Copy link
Member

Cobrand commented Mar 31, 2018

The test failing is obviously not related (although we'll have to look into it at some point), this PR looks good to me so I'm merging it!

@Cobrand Cobrand merged commit 162441b into Rust-SDL2:master Mar 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants