-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wrappers for SDL 2.0.9 rumble functions #824
Conversation
Travis seems to fail without the |
Weird that we didnt catch that earlier. Can you update the travis file to use 2.0.9 real quick? |
Yeah, I'll do that. |
@@ -3,6 +3,9 @@ when upgrading from a version of rust-sdl2 to another. | |||
|
|||
### v0.32 | |||
|
|||
[PR #824](https://github.com/Rust-SDL2/rust-sdl2/pull/824): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the changelog, technically, 0.32 is already released, so make a new category "v0.32.1 (unreleased)" and put those changes there instead. Otherwise, people will wonder why this rumble feature is not part of 0.32 on crates.io.
Other than than, looks good to me! I tested the update example locally on my computer with a Xbox 360 controller, works really well!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I wasn't so sure about that myself... What you proposed sounds good, I'm gonna do that.
Edit: Oh, and I'm glad it also works fine for you! The 2.0.9 rumble feature really is great, especially with the HIDAPI stuff they added.
Add wrappers for SDL 2.0.9 rumble functions
I added
sdl2::controller::set_rumble
andsdl2::joystick::set_rumble
, wrappers for the two new (since SDL 2.0.9) rumble functionsSDL_GameControllerRumble
andSDL_JoystickRumble
respectively.The
game-controller
andjoystick
examples were also extended to test them a little.