Remove num-traits altogether #957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This crate was originally developped when rust didn't have a 1.0 yet, so there are for sure some stuff we can improve, notably with the TryFrom traits and all. In the meantime, thanks for the PR! |
I see. What do you think about my other suggestions? I can make them in a PR as well. |
|
I think your suggestion is a good one (but perhaps you'll encounter issues you didn't expect while changing that, who knows...); but I don't think it is an urgent one. Feel free to drop a PR if you're up for it! |
sypwex
pushed a commit
to sypwex/rust-sdl2
that referenced
this pull request
Jun 2, 2024
Remove num-traits altogether
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I replaced every occurrence of
FromPrimitivewithTryFromwith()as the error type.I also noticed a recurring pattern of casting C enums to uints and then converting uints to Rust enums, perhaps this can be avoided by adding
From/TryFromtraits for converting C enums directly to Rust ones? And someTryFromimplementations can be converted toFromby assuming default values, e.g.PixelFormatEnum::Unknownwhen the pixel format is unknown.