Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aead-stream: extract implementation from the aead crate #627

Merged
merged 9 commits into from
Sep 23, 2024

Conversation

newpavlov
Copy link
Member

@newpavlov newpavlov commented Sep 23, 2024

This PR extracts implementation of the STREAM construction from the aead crate into a separate crate as was proposed in RustCrypto/traits#1665.

@newpavlov newpavlov requested a review from tarcieri September 23, 2024 16:21
@newpavlov newpavlov changed the title aead-stream: move implementation from the aead crate aead-stream: extract implementation from the aead crate Sep 23, 2024
aead-stream/Cargo.toml Outdated Show resolved Hide resolved
Co-authored-by: Tony Arcieri <bascule@gmail.com>
aead-stream/CHANGELOG.md Outdated Show resolved Hide resolved

let mut result = Array::default();

// TODO(tarcieri): use `generic_array::sequence::Concat` (or const generics)
Copy link
Member

@tarcieri tarcieri Sep 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sidebar: should probably fix this, or at least update it to use hybrid-array (in a separate PR seems fine)

@@ -0,0 +1,229 @@
#![no_std]
#![doc = include_str!("../README.md")]
#![allow(clippy::upper_case_acronyms)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be good to fix this in a separate PR

Cargo.lock Outdated Show resolved Hide resolved
@newpavlov newpavlov merged commit 5080931 into master Sep 23, 2024
99 checks passed
@newpavlov newpavlov deleted the aead-stream/init branch September 23, 2024 17:12
newpavlov added a commit to RustCrypto/traits that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants