Use full range of the stream counter for StreamLE31 #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The maximum value of the 31 bit counter should be 0x7FFFFFFF, rather than 0x0FFFFFFF. Using this version allows a stream which has eight times as many messages and is more consistent with the code that calculates the nonce value for the last block which uses `((last_block as u32) << 31`.
|
Sister PR in the crypto traits lib where I originally found this issue on the 0.5.2 release: |
newpavlov
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe that we the
StreamPrimitiveforStreamLE31in the library is not using the correct value forCOUNTER_MAX, choosing0x0FFF_FFFFrather than0x7FFF_FFFF, resulting in a reduced space for the message counter. This commit changes the value to use the full range.I do not believe this is a security issue, but it does reduce the functionality of the library.
Let me know if my understanding of the problem is incorrect or if I'm attempting to commit this to the wrong library.