-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ANSI-X9.63-KDF #102
Add ANSI-X9.63-KDF #102
Conversation
…tch SEC 1 convention
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have several comments, but otherwise looks good!
Please also add a CI job to test this crate (see the .github/workflows
folder).
You can update the Clippy version to 1.81 in the workspace.yml config to fix the failing CI. |
Thanks for reviewing! I tried and addressed your comments. The MSRV bump does trigger a failing clippy at workspace level though. |
Thank you! |
Thanks for the review and the tweaks!
In the meantime, I'll close the issue. |
The MSRV badge (rustc 1.81+) renders fine for me. Docs and crates.io badges require publishing to crates.io, which we will do after releasing digest v0.11.
Yes. I plan to do it a bit later. |
Adding support for ANSI X9.63 Key Derivation Function (ANSI-X9.63-KDF).
ANSI-X9.63-KDF is defined in SEC.1 and is the recommended KDF to be used for CMS with ECC - as per RFC 5753.
This would close issue #101.
Overview:
This pull request:
ansi-x963-kdf
crate with:ansi_x963_kdf::derive_key_into
functionREADME.md
withansi-x963-kdf
Notes: