Critical options String values double-length encoding #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
reviewed
Mar 21, 2024
tarcieri
reviewed
Mar 21, 2024
tarcieri
reviewed
Mar 21, 2024
|
Looks like I broke some tests, going to look at that. |
|
I've had to special case 0-len values because we don't want to double-length-prefix those. |
tarcieri
approved these changes
Mar 22, 2024
baloo
added a commit
to baloo/SSH
that referenced
this pull request
Apr 12, 2024
Added: - impl `decode_as` for `KeypairData` ([RustCrypto#211]) Changed: - clarify SSH vs OpenSSH formats ([RustCrypto#206]) Fixed: - fix `certificate::OptionsMap` encoding ([RustCrypto#207]) - fixup `EcdsaPrivateKey` Debug impl ([RustCrypto#210]) [RustCrypto#206]: RustCrypto#206 [RustCrypto#207]: RustCrypto#207 [RustCrypto#210]: RustCrypto#210 [RustCrypto#211]: RustCrypto#211
Merged
baloo
added a commit
that referenced
this pull request
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was recent clarification on how critical options values should be read: https://bugzilla.mindrot.org/show_bug.cgi?id=2389
The gist of it is that values can be of any kind, but they generally are strings. To support more types, the value is encoded in a more generic way. For a string, this means there are 2 length prefixes (4 bytes for the total length of the value and then 4 bytes for the length of the string).
This PR aims at fixing this issue.