Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssh-key: Add Certificate::decode_as and expose KeyData::decode_as #233

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

wiktor-k
Copy link
Contributor

@wiktor-k wiktor-k commented Jul 9, 2024

This additional function is needed for SSH Agent Protocol where, based on
the algorithm, we need to parse the Certificate or the KeyData.

Without decode_as the decode function will greedily consume additional
string from the reader.

This is similar to #211.

See: wiktor-k/ssh-agent-lib#83

wiktor-k added 2 commits July 9, 2024 14:47
Signed-off-by: Wiktor Kwapisiewicz <wiktor@metacode.biz>
This additional function is needed for SSH Agent Protocol where, based on
the algorithm, we need to parse the `Certificate` or the `KeyData`.

Without `decode_as` the `decode` function will greedily consume additional
string from the reader.

See: wiktor-k/ssh-agent-lib#83
Signed-off-by: Wiktor Kwapisiewicz <wiktor@metacode.biz>
wiktor-k added a commit to wiktor-k/ssh-agent-lib that referenced this pull request Jul 9, 2024
See: RustCrypto/SSH#233
Signed-off-by: Wiktor Kwapisiewicz <wiktor@metacode.biz>
@tarcieri tarcieri merged commit bbf54df into RustCrypto:master Jul 10, 2024
12 checks passed
@wiktor-k wiktor-k deleted the expose-decode-as branch July 10, 2024 08:39
@wiktor-k
Copy link
Contributor Author

Hi @tarcieri, sorry to disturb but I'm wondering if you're planning on releasing -pre version of ssh-key (and/or related crates)? I'd unblock me from releasing a new version of ssh-agent-lib.

Thanks for your time!

@tarcieri
Copy link
Member

Sure, I can cut some prereleases, although I'll need to cut prereleases of the dependencies first (which is something I planned on doing soon anyway)

@wiktor-k
Copy link
Contributor Author

That's great to hear. Thanks! 🙇‍♂️

@wiktor-k
Copy link
Contributor Author

If you don't mind I'll ping you every now and then @tarcieri 👋

@tarcieri
Copy link
Member

It might be awhile. There are dozens upon dozens of downstream dependencies to do prereleases of.

@tarcieri
Copy link
Member

Release PR here: #250

I had to temporarily remove the ed25519 feature to make it possible

@wiktor-k
Copy link
Contributor Author

Thank you 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants