ssh-cipher: make ChaCha20Poly1305 accept a 256-bit key #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the OpenSSH protocol, ChaCha20Poly1305 uses two different keys: one for length encryption, and one for payloads. It wasn't previously possible to use both keys (or at least quite obtuse) because `ssh-cipher` chopped up `k_1` and `k_2` and only allowed `k_1` to be used. This change hoists that into `ssh-key` for file encryption uses, giving access to the raw `ChaCha20Poly1305` implementation and allowing use of either key. In addition, a nonce is now mandatory, but use of the default all-zero nonce for file encryption purposes is now handled in `ssh-key`.
tarcieri
force-pushed
the
ssh-cipher/lower-level-chacha20poly1305-support
branch
from
5088a73 to
8b34eb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the OpenSSH protocol, ChaCha20Poly1305 uses two different keys: one for length encryption, and one for payloads.
It wasn't previously possible to use both keys (or at least quite obtuse) because
ssh-cipherchopped upk_1andk_2and only allowedk_1to be used.This change hoists that into
ssh-keyfor file encryption uses, giving access to the rawChaCha20Poly1305implementation and allowing use of either key.In addition, a nonce is now mandatory, but use of the default all-zero nonce for file encryption purposes is now handled in
ssh-key.