ssh-key: make all RSA private key fields private #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds fallible constructors, and uses those in the `Decode` impls. The new constructors ensure the provided `Mpints` are non-negative.
tarcieri
added a commit
that referenced
this pull request
Aug 13, 2024
Like we did for RSA in #274, this makes all fields of DSA keys private, and also validates that their inner `Mpint`s are positive.
tarcieri
added a commit
that referenced
this pull request
Aug 13, 2024
Like we did for RSA in #274, this makes all fields of DSA keys private, and also validates that their inner `Mpint`s are positive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds fallible constructors, and uses those in the
Decodeimpls.The new constructors ensure the provided
Mpints are non-negative.