Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change compression functions to accept &[Block] instead of &Block #26

Closed
newpavlov opened this issue Jan 13, 2021 · 2 comments
Closed

Change compression functions to accept &[Block] instead of &Block #26

newpavlov opened this issue Jan 13, 2021 · 2 comments

Comments

@newpavlov
Copy link
Member

newpavlov commented Jan 13, 2021 •
edited
Loading

It will allow us to prevent hasher state from spilling to memory after processing each block (e.g. by encoding tight loop inside assembly).
@newpavlov newpavlov mentioned this issue Jan 13, 2021
Merged
newpavlov added a commit to RustCrypto/hashes that referenced this issue Jan 13, 2021
@newpavlov
Remove asm-related TODO comments (#215)
0215edc 
Closes #213

The comments are removed in favor of RustCrypto/asm-hashes#26.
This was referenced Jan 26, 2021
Closed
Merged
@newpavlov
Copy link
Member Author

Public API of the crates has been appropriately changed, but assembly still processes one block at a time.

@newpavlov
Copy link
Member Author

We decided to deprecate these crates and future ASM backends will be implemented directly in the hash implementations crats.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@newpavlov