Fix deprecated use of cc::Build::compile
in build.rs
#59
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and fixed the path to assemblies on windows.
I encountered link time failure when compiling on Windows locally and on CI:
I think this might have something to do with use of deprecated feature of
cc::Build::compile
:It should pass just a name instead and msvc would deal with that:
Also, thebuild.rs
are using/
on windows, this might also be the cause of failure.Related issue Byron/gitoxide#917
Signed-off-by: Jiahao XU Jiahao_XU@outlook.com