-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XTS Mode #74
base: master
Are you sure you want to change the base?
XTS Mode #74
Conversation
Okay, I found the underlying issue: For now, I will do like the |
Opened up for review, since the All IEEE 1619-2018 tests passes, parallel computing is supported, and doc is done. |
Made a rookie mistake, the GF operations are not constant time. This should be an easy fix |
Right now I work on other things, so I will try to take a look at this in a week or two. |
I implemented the trait on the
pre
release ofcipher
.Suggestions for the
cipher
crate:cts
crate simply bypasses the trait system and implement the encryption methods directly on the struct.Missing:
cipher
traits correctly (cannot actually be done, see comment below)InOut
-based methods, as I initially wrote the implementation in-place.If you've got any suggestion for the first point, it would be appreciated!