-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect Object Identifier DER Encoding #1520
Comments
This also seems to fail for many For instance
|
Reproduced. Thanks for the report. |
tarcieri
added a commit
that referenced
this issue
Sep 18, 2024
BER encodings were being miscomputed for certain large arcs. The previous method was a bit wacky (in addition to being buggy) and attempted to encode each arc backwards within the BER output buffer. This switches to a new method which splits the upper 7 bits from an arc and encodes that as a byte, continuing until all bytes of the arc have been encoded, which is much more straightforward. The problematic cases which were reported have now been corrected. Fixes #1520
tarcieri
added a commit
that referenced
this issue
Sep 18, 2024
BER encodings were being miscomputed for certain large arcs. The previous method was a bit wacky (in addition to being buggy) and attempted to encode each arc backwards within the BER output buffer. This switches to a new method which splits the upper 7 bits from an arc and encodes that as a byte, continuing until all bytes of the arc have been encoded, which is much more straightforward. The problematic cases which were reported have now been corrected. Fixes #1520
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The encoding seems to be incorrect for certain object identifiers at the boundary of arc length. For example:
I'm using this crate:
The text was updated successfully, but these errors were encountered: