pem-rfc7468: add detect_base64_line_width and new_detect_wrap
#1464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the following new functions: - `detect_base64_line_width`: a toplevel free function similar to `decode_label` which outputs an autodetected line width for a given input PEM byte slice. - `Decoder::new_detect_wrap`: an alternative to `Decoder::new_wrapped` which attempts to autodetect the Base64 line width in order to flexibly handle inputs wrapped at any size. For an initial implementation, empty space between the pre-encapsulation boundary and the start of the Base64 is not handled.
tarcieri
added a commit
to RustCrypto/SSH
that referenced
this pull request
Jul 28, 2024
Uses the line width detection support added to `pem-rfc7468` in RustCrypto/formats#1464 to automatically detect the input line width and parse PEM documents accordingly, which allows support for a wider range of SSH keys which don't use the default 70 chars of line wrapping. Closes #195
tarcieri
added a commit
to RustCrypto/SSH
that referenced
this pull request
Jul 28, 2024
Uses the line width detection support added to `pem-rfc7468` in RustCrypto/formats#1464 to automatically detect the input line width and parse PEM documents accordingly, which allows support for a wider range of SSH keys which don't use the default 70 chars of line wrapping. Fixes #195
tarcieri
added a commit
to RustCrypto/SSH
that referenced
this pull request
Jul 28, 2024
Uses the line width detection support added to `pem-rfc7468` in RustCrypto/formats#1464 to automatically detect the input line width and parse PEM documents accordingly, which allows support for a wider range of SSH keys which don't use the default 70 chars of line wrapping. Fixes #195
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the following new functions:
detect_base64_line_width: a toplevel free function similar todecode_labelwhich outputs an autodetected line width for a given input PEM byte slice.Decoder::new_detect_wrap: an alternative toDecoder::new_wrappedwhich attempts to autodetect the Base64 line width in order to flexibly handle inputs wrapped at any size.For an initial implementation, empty space between the pre-encapsulation boundary and the start of the Base64 is not handled.