Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sha2: provide support for spki::AlgorithmIdentifier #586

Closed
wants to merge 1 commit into from

Conversation

baloo
Copy link
Member

@baloo baloo commented May 22, 2024

This implements AlgorithmIdentifier according to RFC5754 section 2

Depends on RustCrypto/traits#1575

This implements `AlgorithmIdentifier` according to [RFC5754 section 2]

[RFC5754 section 2]: https://www.rfc-editor.org/rfc/rfc5754#section-2
@baloo baloo force-pushed the baloo/sha2/spki-support branch from dbd6271 to e478086 Compare May 22, 2024 18:22
@baloo
Copy link
Member Author

baloo commented May 23, 2024

From the RFC:

   The AlgorithmIdentifier parameters field is OPTIONAL.
   Implementations MUST accept SHA2 AlgorithmIdentifiers with absent
   parameters.  Implementations MUST accept SHA2 AlgorithmIdentifiers
   with NULL parameters.  Implementations MUST generate SHA2
   AlgorithmIdentifiers with absent parameters.

This implementation generates AlgorithmIdentifier with parameters absent, but it would be nice if we could also provide a PartialEq that accepted NULL parameters.

(same situation exists in https://www.rfc-editor.org/rfc/rfc3370#section-2.1 for Sha1)

cc @carl-wallace

@baloo baloo closed this Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant