Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing tests in sha2 #603

Closed
wants to merge 2 commits into from
Closed

Conversation

CXWorks
Copy link

@CXWorks CXWorks commented Jul 17, 2024

Hi,

Thanks for your time & patience to review this PR.

By examine the existing code, I found some unit tests(7 in total) can be added to improve the repo sha2 module's overall unit test coverage(this project is already been well tested). Each of the unit test is testing a different target function for better coverage.

Thanks again for reviewing.

Copy link
Member

@newpavlov newpavlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure we need these tests to artificially boost test coverage. A proper coverage measurement should merge several runs which trigger different backends, e.g. by using the crate configuration options.

sha2/src/sha512/x86.rs Show resolved Hide resolved
@CXWorks
Copy link
Author

CXWorks commented Jul 23, 2024

I am not sure we need these tests to artificially boost test coverage. A proper coverage measurement should merge several runs which trigger different backends, e.g. by using the crate configuration options.

Thanks for your comments and good question. Honestly we don't know a good answer for this question or if this project has a testing coverage plan, but we are happy to get different feedbacks

@newpavlov
Copy link
Member

Closing this PR since the added test do not test much.

@newpavlov newpavlov closed this Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants