Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

argon2: Add const compatibility #438

Merged
merged 23 commits into from
Aug 7, 2023
Merged

argon2: Add const compatibility #438

merged 23 commits into from
Aug 7, 2023

Conversation

C0D3-M4513R
Copy link
Contributor

Closes #436

newpavlov
newpavlov reviewed Jul 3, 2023
View reviewed changes
argon2/src/params.rs Outdated Show resolved Hide resolved
tarcieri
tarcieri reviewed Jul 3, 2023
View reviewed changes
argon2/Cargo.toml Outdated Show resolved Hide resolved
tarcieri
tarcieri reviewed Jul 3, 2023
View reviewed changes
argon2/src/params.rs Outdated Show resolved Hide resolved
tarcieri
tarcieri reviewed Jul 3, 2023
View reviewed changes
argon2/src/params.rs Outdated Show resolved Hide resolved
@C0D3-M4513R @tarcieri
Add tarcieri's change
524de64 
Co-authored-by: Tony Arcieri <bascule@gmail.com>
@C0D3-M4513R C0D3-M4513R requested a review from tarcieri July 3, 2023 16:04
@C0D3-M4513R
Copy link
Contributor Author

Ah 383be35 only works in nightly... I had a rust override set for that folder

@C0D3-M4513R C0D3-M4513R changed the title Add const compatibility argon2: Add const compatibility Jul 4, 2023
@tarcieri tarcieri merged commit 5e3f574 into RustCrypto:master Aug 7, 2023
13 checks passed
@tarcieri
Copy link
Member

tarcieri commented Aug 7, 2023 •
edited
Loading

It seems I merged this after #440 which is not compatible with these changes, namely it introduced runtime CPU feature detection which is not const-friendly.

I'm going to revert for now: #447

tarcieri added a commit that referenced this pull request Aug 7, 2023
@tarcieri
Revert "argon2: improve const compatibility (#438)"
bb63e6c 
This reverts commit 5e3f574.

These changes are incompatible with #440, which performs runtime CPU
feature detection.
tarcieri added a commit that referenced this pull request Aug 7, 2023
@tarcieri
Revert "argon2: improve const compatibility (#438)" (#447)
e19aabd 
This reverts commit 5e3f574.

These changes are incompatible with #440, which performs runtime CPU
feature detection.
@C0D3-M4513R C0D3-M4513R mentioned this pull request Aug 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarcieri tarcieri tarcieri approved these changes

@newpavlov newpavlov Awaiting requested review from newpavlov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

argon2: const ParamsBuilder
3 participants
@C0D3-M4513R @tarcieri @newpavlov