Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream-cipher: remove NewBlockCipher bound on FromBlockCipher #333

Merged
merged 1 commit into from
Oct 14, 2020
Merged

stream-cipher: remove NewBlockCipher bound on FromBlockCipher #333

merged 1 commit into from
Oct 14, 2020
+7 −6

Commits on Oct 14, 2020

  1. stream-cipher: remove NewBlockCipher bound on FromBlockCipher 

    Note: breaking change.

As far as I can tell this was an oversight: `FromBlockCipher` never
needs to instantiate a new block cipher (isn't that the point?),
making this bound needlessly limiting.

The rationale for it in the first place appears to be for the blanket
impl of `NewStreamCipher` for `C: FromBlockCipher` which needs it, but
we can add the bound to the blanket impl, rather than (needlessly)
sticking it on the trait.
    @tarcieri
    tarcieri committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    b24065e View commit details
    Browse the repository at this point in the history